Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch-later from fullscreen window contains wrong border information #11575

Open
christoph-heinrich opened this issue Apr 12, 2023 · 3 comments

Comments

@christoph-heinrich
Copy link
Contributor

Important Information

Provide following Information:

  • mpv 0.35.0-363-gc50f536bd1
  • Arch Linux
  • compiled from source
  • KDE Plasma 5.27.4 on Wayland
  • Mesa 23.0.2

Reproduction steps

  1. Create a directory with a mpv.conf containing border=no
  2. mpv --config-dir=<path to aforementioned directory> <path to some video file>
  3. Fullscreen the video
  4. Quit with Shift+q to save watch-later information
  5. Run the same mpv command again
  6. Exit fullscreen

Expected behavior

Window has no border

Actual behavior

Window has a border.

The file with the watch-later information (~~/watch-later/<hash>) contains border=yes instead of border=no.

Log file

log from first run
log from second run

@Dudemanguy
Copy link
Member

This is almost certainly because the border option works weirdly on wayland. Although I wouldn't have expected this to happen.

@christoph-heinrich
Copy link
Contributor Author

Apparently border even gets set to true while in fullscreen, so it makes sense that watch-later would act that way.

@Dudemanguy
Copy link
Member

It looks like the compositor sets the border when going into fullscreen. That's pretty weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants