Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extremely bad codegen on Fp2 #146

Closed
mratsim opened this issue Feb 1, 2021 · 1 comment · Fixed by #153
Closed

Extremely bad codegen on Fp2 #146

mratsim opened this issue Feb 1, 2021 · 1 comment · Fixed by #153
Labels
performance 🏁 upstream 🐉

Comments

@mratsim
Copy link
Owner

mratsim commented Feb 1, 2021 •
edited
Loading

Might be the same rootcause as #145, no comment

image

Since Fp2 is a concept, I wonder if concept don't respect the rules of Nim parameter passing (i.e. by reference if over 24 bytes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance 🏁 upstream 🐉
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tower drop concepts mratsim/constantine
1 participant
@mratsim