Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): checkOnSave = false not respected if clippy is installed #230

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix(lsp): checkOnSave = false not respected if clippy is installed #230

merged 1 commit into from
Feb 12, 2024

Conversation

mrcjkb
Copy link
Owner

@mrcjkb mrcjkb commented Feb 12, 2024

Fixes #228

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2024 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@mrcjkb mrcjkb enabled auto-merge (squash) February 12, 2024 20:22
@mrcjkb mrcjkb merged commit ae759e6 into master Feb 12, 2024
9 checks passed
@mateuszaaa
Copy link

maaaan you rocks!

@mrcjkb mrcjkb deleted the fix-checkOnSave-false-clippy branch February 12, 2024 21:32
This was referenced Nov 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] checkOnSave = false not respected if clippy is installed.
2 participants
@mrcjkb @mateuszaaa