Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(termopen): "<Esc>" to close buffer not silent #392

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(termopen): "<Esc>" to close buffer not silent #392

merged 1 commit into from
May 16, 2024

Conversation

b1nhack
Copy link
Contributor

@b1nhack b1nhack commented May 15, 2024

Use ":" to enter command mode, not silent by default.
In addition to this, using <Cmd>...<CR> has many advantages:
https://neovim.io/doc/user/map.html#%3CCmd%3E

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mrcjkb mrcjkb changed the title fix: "<Esc>" close buffer not silent fix(termopen): "<Esc>" to close buffer not silent May 16, 2024
@mrcjkb mrcjkb merged commit 253ce04 into mrcjkb:master May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants