fix(enable_clippy): use correct rust-analyzer config key #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct config key for a rust-analyzer check command table is `check`. `checkOnSave` is a boolean (there are some hints in the manual that `checkOnSave` as a table is aliased to `check` but even if it is the correct key is `check`) this prevents incorrect config conflicts downstream
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
approved these changes
May 20, 2024
|
ah shoot, I messed it up. give me a few. |
mrcjkb
approved these changes
May 22, 2024
1 task
folke
pushed a commit
to LazyVim/LazyVim
that referenced
this pull request
Jun 14, 2024
## What is this PR for? After recent changes in `rustaceanvim` in mrcjkb/rustaceanvim#403, `checkOnSave` is supposed to be boolean and the table that we were passing to `checkOnSave` previously should be passed to `check` instead. I left the `check` table undefined, because the options that we were passing to `checkOnSave` before are the default ones being passed to `check`. So, only if the user wants to change something should he change the values of the `check` table according to what he wants. ## Does this PR fix an existing issue? No ## Checklist - [x] I've read the [CONTRIBUTING](https://github.com/LazyVim/LazyVim/blob/main/CONTRIBUTING.md) guidelines.
ueaner
added a commit
to ueaner/nvimrc
that referenced
this pull request
Jun 20, 2024
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct config key for a rust-analyzer check command table is
check.checkOnSaveis a boolean.https://rust-analyzer.github.io/manual.html#configuration
There are some hints in the manual that
checkOnSaveas a table is aliased tocheckbut even if it is the correct key ischeck.This prevents incorrect config conflicts downstream.