Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): nil safety in codeAction Group #487

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Aug 25, 2024

Using #M.state.actions.group stops (and returns 0) when a nil is encountered.

Use vim.tbl_count() instead which will return an integer

Using #M.state.actions.group stops (and returns 0) when a nil is encountered.

Use vim.tbl_count() instead which will return an integer
Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@dsully dsully changed the title Fix codeAction Group + ui_select_fallback fix: codeAction Group + ui_select_fallback Aug 25, 2024
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

I'll prepare a new release when I'm near my laptop.

@mrcjkb mrcjkb changed the title fix: codeAction Group + ui_select_fallback fix(ui): nil safety in codeAction Group Aug 26, 2024
@mrcjkb mrcjkb merged commit 6d994af into mrcjkb:master Aug 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants