Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable color for neotest #554

Open
Jasha10 opened this issue Oct 28, 2024 · 2 comments
Open

Re-enable color for neotest #554

Jasha10 opened this issue Oct 28, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Jasha10
Copy link

Jasha10 commented Oct 28, 2024

Feature description

PR #461 disabled color output for neotest by passing --color=never to cargo.
This worked around an issue where one test failure caused all succeeding tests to be marked as failed (#460).

When I set --color=always in the lua/neotest/init.lua file, I'm not currently able to reproduce the issue where one failure caused succeeding tests to be marked as failed. Would it be possible to re-enable color in the rustaceanvim neotest adapter (or make color configurable)?

@Jasha10 Jasha10 added the enhancement New feature or request label Oct 28, 2024
@mrcjkb
Copy link
Owner

mrcjkb commented Oct 28, 2024

Hey 👋

sure, I could put it behind a config option.
I'm busy right now, but perhaps I'll find some time later this week.
Otherwise, PRs are welcome 😄

@Ydot19
Copy link

Ydot19 commented Nov 1, 2024

@mrcjkb I would like to claim this issue. Validating a draft PR as linked in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants