Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/build/build.js sourcemaps are not correct #8819

Closed
3 of 12 tasks
abelnation opened this issue May 6, 2016 · 2 comments
Closed
3 of 12 tasks

utils/build/build.js sourcemaps are not correct #8819

abelnation opened this issue May 6, 2016 · 2 comments

Comments

@abelnation
Copy link
Contributor

abelnation commented May 6, 2016

Description of the problem

The sourcemaps that result from build.js do not appear correct. I think there are a couple of contributing problems:

  • some source files are preprocessed before being concatenated together into the final source. This means that the line numbers referenced by the sourcemap will not match up correctly with the source files on the filesystem.
  • no real sourcemap is generated at all for the non-minified version of the build
  • mangled variable names don't seem to get mapped back properly (at least in chrome)

I think a tool like concat-with-sourcemaps might be a nice approach for the non-minified version (working on a branch for that).

The uglified sourcemap is a trickier problem. I can't get the sourcemap to quite line up right w/ the src files.

I think the primary goal is to make source mapping work for the non-minified version, as that is the version that people will develop/debug with, making the sourcemap a more critical working element.

...

Three.js version
  • Dev
  • r76
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Mac
  • Linux
  • Android
  • IOS
Hardware Requirements (graphics card, VR Device, ...)
@bhouston
Copy link
Contributor

bhouston commented May 6, 2016

I did try to get them fixed in this PR: #8366

@abelnation
Copy link
Contributor Author

closing this issue, as the conversation seems to be going in #8366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants