Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a temporary fix for #254 #256

Closed
mrmlnc opened this issue Feb 20, 2020 · 3 comments
Closed

Remove a temporary fix for #254 #256

mrmlnc opened this issue Feb 20, 2020 · 3 comments
Assignees
@mrmlnc
Labels
Type: Maintenance
Milestone
3.2.6

Comments

@mrmlnc
Copy link
Owner

mrmlnc commented Feb 20, 2020

Source

Blockers
@mrmlnc mrmlnc self-assigned this Feb 20, 2020
@mrmlnc mrmlnc added this to the 3.x.x milestone Feb 20, 2020
@mrmlnc mrmlnc mentioned this issue Feb 20, 2020
Closed
@devongovett
Copy link

I think switching to picomatch for this has broken some things like brace expansion. I inadvertently upgraded to 3.2.1 via a transitive dependency and things started breaking.

@mrmlnc
Copy link
Owner Author

mrmlnc commented Feb 20, 2020 •
edited
Loading

This is weird, because we expand brace expansion in advance and… micromatch call picomatch directly.

Can you provide steps to reproduce your problem?

@devongovett
Copy link

Sorry, this appears to be a separate issue. #257

@mrmlnc mrmlnc modified the milestones: 3.x.x, 3.2.6 Jun 21, 2021
@mrmlnc mrmlnc mentioned this issue Jun 22, 2021
Merged
@mrmlnc mrmlnc closed this as completed Jun 22, 2021
@rntvicente rntvicente mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrmlnc mrmlnc

Labels
Type: Maintenance
Projects
None yet
Milestone
3.2.6
Development

No branches or pull requests
2 participants
@devongovett @mrmlnc