Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in v3.3.1 #422

Closed
fisker opened this issue Aug 28, 2023 · 3 comments
Closed

Regression in v3.3.1 #422

fisker opened this issue Aug 28, 2023 · 3 comments
Milestone

Comments

@fisker
Copy link

fisker commented Aug 28, 2023

Environment

  • OS Version: Linux
  • Node.js Version: 18

Actual behavior

I have files

foo/bar.a
foo\/bar.a
# Note: The second dirname is `foo\`
> require('fast-glob').sync("foo@(\\\\)/**/{*.a,*.b}")
[] 
> require('fast-glob').sync("foo@(\\\\)/**/*")
[ 'foo\\/bar.a' ]
> require('fast-glob').sync("foo/**/*")
[ 'foo/bar.a' ]
> require('fast-glob').sync("foo/**/{*.a,*.b}")
[ 'foo/bar.a' ]

Expected behavior

Expect

require('fast-glob').sync("foo@(\\\\)/**/{*.a,*.b}")

to glob foo\/bar.a file, and previous version work as expected.

Steps to reproduce

N/A

Code sample

N/A

@fisker
Copy link
Author

fisker commented Aug 28, 2023

Just noticed, in previous version

require('fast-glob').sync("foo@(\\\\)/**/{*.a,*.b}")

works,

require('fast-glob').sync("foo@(\\\\)/{*.a,*.b}")

not work either.

@mrmlnc
Copy link
Owner

mrmlnc commented Sep 20, 2023

Fixed in the main branch and was backported to 3.x.x.

@mrmlnc mrmlnc closed this as completed Nov 6, 2023
@mrmlnc
Copy link
Owner

mrmlnc commented Nov 6, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants