Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Keywords in strings in code not ignored #200

Open
dsanalytics opened this issue May 10, 2018 · 2 comments
Open

BUG: Keywords in strings in code not ignored #200

dsanalytics opened this issue May 10, 2018 · 2 comments

Comments

@dsanalytics
Copy link

Hi, todo finds and lists keywords even if when are just code strings - e.g. print('REVIEW DETAILS") gets that line listed in todos. Thanks in advance.

OS: Win10 64bit
Atom: 1.23.2 x64

P.S. Thanks for the great plugin

@mrodalgaard
Copy link
Owner

I have yet to find a good way to register if a found string is in code or comment, that works across all languages. Until then; this is the behaviour to not accidentally hide todos for some.

@mrodalgaard mrodalgaard self-assigned this Aug 25, 2018
@mrodalgaard mrodalgaard removed their assignment Aug 25, 2018
@willlma
Copy link

willlma commented Jan 10, 2019

An example of this happening in Rails erb file if it's helpful:

<%= link_to("REVIEW ORDER", … %>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants