Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Clarify maxbodylength messaging #90

Open
mcandre opened this issue Mar 21, 2023 · 1 comment
Open

Enhancement: Clarify maxbodylength messaging #90

mcandre opened this issue Mar 21, 2023 · 1 comment

Comments

@mcandre
Copy link

mcandre commented Mar 21, 2023

There are many ways to calculate the length of some text. Bytes, characters, runes, words, lines...

I think the maxbodylength rule operates on lines, but the current warning string format does not appear to say this explicitly. Can we please add the word "line" just before "length" in the output?

@MattOates
Copy link

It doesn't operate on lines, it operates on parsed/tokenised Make commands, so a single shell thats got a tonne of continuations and semicolons counts as a single "line". Which actually makes this feature especially irritating as it ignores the 500 lines of shell in a phony but complains if you have a 3 line target with some echo statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants