Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] TikzGraphs as conditional dependency + text-based output method #73

Closed
svilupp opened this issue Nov 24, 2022 · 4 comments
Closed

Comments

@svilupp
Copy link
Contributor

svilupp commented Nov 24, 2022

Thank you for the great package!

Unfortunately, TikzGraphs dependency makes it impossible to add for users with M1 Macs. It's linked to Tectonic binaries (see link), which get pulled in with TikzGraphs->TikzPictures->Tectonic.

I'd be happy to open a PR to add a fallback text-based output and load plotting with TikzGraphs via Requires.

Otherwise, I've tested the functionality (by dev'ing and removing manually the Tikz dependencies) and all seems to work as expected.

@mschauer
Copy link
Owner

Please make a PR, that would be great!

@svilupp
Copy link
Contributor Author

svilupp commented Dec 9, 2022

Sorry for being so slow!

Two questions that will help me focus energy:

  • Should I write the conditional deps in the new "package extensions" style that is backwards compatible? (PGFXPlotx example here) Or rather stick to Requires.jl?
  • I have not found a simple generic way to display a graph via text without too much effort. I'm considering just sorting them printing a bit and then printing the edge in a tabular format (ala TabularDisplay) - It's better than nothing having an output at all. Would that be sensible?

@mschauer
Copy link
Owner

Let's go by "Perfect is the enemy of good"? Tabular display would be helpful and only do the new style if it doesn't stall you. I am happy anyway if you and me are able to fix the problem.

@mschauer
Copy link
Owner

Closed by #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants