-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msgpack-c calls the double in msgpack_object_union illogically dec
#191
Comments
@ztane, thank you for your comment.
True. It is misleading. 'dec' is corresponding to 'float format family': It should have a different name. But it is already a part of public interface. It might break existing client codes. So I think that the next MAJOR version up is a good timing to change the name.
I'm trying to improve the documentation. But it is under development. Here is information about dec: https://github.com/msgpack/msgpack-c/wiki/cpp_object#what-is-msgpackobject Unfortunately it is in the picture. So it can't be hit as a search word. By the way, I think that 'f64' is a good name. 'float' is reserved by the languace C/C++. 'f64' is the same mannar as 'i64' and 'u64'. |
I discussed this with redboltz. Because we use union, we can add a new |
I added a document on the wiki https://github.com/msgpack/msgpack-c/wiki/cpp_configure |
which most probably refers to "decimal", which the doubles after all are not, as they are encoded in IEEE-754 binary.
Furthermore, since the documentation seems to be "read the source", I had to read the headers to find it out.
The text was updated successfully, but these errors were encountered: