Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing failure for pages containing pictures #11

Open
flxzt opened this issue Aug 5, 2023 · 3 comments · May be fixed by #15
Open

parsing failure for pages containing pictures #11

flxzt opened this issue Aug 5, 2023 · 3 comments · May be fixed by #15

Comments

@flxzt
Copy link

flxzt commented Aug 5, 2023

The latest version of the OneNote web app apparently inserts images without a "last modified" time or the parser parses this property incorrectly, which causes a failure when parsing the downloaded .one file with this crate.

The error I am encountering is: Malformed OneNote file data: image has no last modified time which seems to originate from image_node.rs#L50

It might be better to make this property fall back to the epoch or something like that?

Thanks for writing this crate!

Edit: after applying this fix in my fork I am stumbling over more and more issues. The last modified property doesn't exist/doesn't get parsed correctly for any objects in the file and I am also getting an Malformed OneNote data: paragraph styling is missing Error for rich text objects. Probably more to come when that is resolved.

I am not sure if an incompatible break in the file format happened or if the parsing is not robust enough in certain cases.

@flxzt flxzt changed the title pages containing pictures cause parsing failure parsing failure for pages containing pictures Aug 5, 2023
@msiemens
Copy link
Owner

Hey @flxzt, is there a chance you could create an example notebook that exhibits these issues and upload it here?

@flxzt
Copy link
Author

flxzt commented Aug 15, 2023

Sure, this is a note containing some handwritten strokes, rich text and a Png:

Bildschirmfoto vom 2023-08-15 14-49-26

Schnelle Notizen.zip

@einsJannis
Copy link

is this being worked on by someone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants