Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to (re)symbolificate saved profile data #83

Open
loonatick-src opened this issue Dec 22, 2023 · 3 comments
Open

Unable to (re)symbolificate saved profile data #83

loonatick-src opened this issue Dec 22, 2023 · 3 comments

Comments

@loonatick-src
Copy link

loonatick-src commented Dec 22, 2023

I have been saving profiles to disk using --output my_profile.json, and after running samply record, the resulting visualization in the local server is symbolificated just fine. But when I reopen the file later from profiler.firefox.com using "load a profile from file", the the stack traces show entirely raw address values, but the session still says "Profile is symboilcated". Clicking on resymbolificate does not help.

I am not sure if this is a samply issue or a firefox profiler issue. Is there a way to explicitly save symbolification information with the sample data or provide symbolification information after loading a profile into the firefox sampler?

Platform: macOS 14.1 23B2073 arm64

@loonatick-src loonatick-src changed the title Unable to (re)symbolify saved profile data Unable to (re)symbolificate saved profile data Dec 22, 2023
@mstange
Copy link
Owner

mstange commented Dec 22, 2023

To load a saved my_profile.json in the profiler with working symbols, you need to use samply load my_profile.json .

You're not the first person to run into this, it's definitely a rough edge.

@kemingy
Copy link

kemingy commented Jul 31, 2024

To load a saved my_profile.json in the profiler with working symbols, you need to use samply load my_profile.json .

You're not the first person to run into this, it's definitely a rough edge.

Hi @mstange, thanks for the awesome tool, how can I share the profile with symbolification information to others? I found that if others samply load profile.json, there is no symbolification information. The paths in the file are fixed to my local path.

@mstange
Copy link
Owner

mstange commented Jul 31, 2024

The easiest way is to upload the profile in the Firefox Profiler UI, with the "Upload Local Profile" button in the top right corner.
If you don't want to upload the profile, you can click that button but then click "Download" in the panel that drops out of it. The downloaded JSON file will contain symbols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants