Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Breaches tab and breach list view in Monitoring page #2283

Closed
Tracked by #1955
roxy-dao opened this issue Sep 25, 2023 · 3 comments
Closed
Tracked by #1955

Add Breaches tab and breach list view in Monitoring page #2283

roxy-dao opened this issue Sep 25, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request feature: coldchain Priority: Must Have The product will not work without this
Milestone

Comments

@roxy-dao
Copy link
Contributor

roxy-dao commented Sep 25, 2023

Is your feature request related to a problem? Please describe 👀

Cold chain needs a way to view breaches in the UI.

Describe the solution you'd like 🎁

  • The monitoring page has 3 tabs ( only implementing the breach tab in this issue )
  • Hook to query temperature_logs and ( hook to update temperature log comment - comment not yet implemented tho...)
  • Columns:
    • Status. Icon for unacknowledged breaches: Group 125
    • Sensor name
    • Storage location
    • CCE
    • Breach start (datetime)
    • Breach end (datetime)
    • Duration (minutes)
    • Ongoing
    • Hot or cold. Cold icon: 🦆 icon snow flake Hot icon: 🦆 icon sun light
    • Highest/Lowest Temperature
    • Type
    • Comment ( will need backend/mSupply issue first to implement )

UI mockup:
Screenshot 2023-10-12 at 12 01 05

Estimate

6 hours

Moneyworks Jobcode 🧰

OMS:COLC

@roxy-dao roxy-dao changed the title Breach view Monitoring -> Breach tab Sep 25, 2023
@roxy-dao roxy-dao removed this from the Basic Coldchain Implementation milestone Sep 26, 2023
@adamdewey
Copy link
Contributor

adamdewey commented Sep 26, 2023

Couple of observations:

  • Think the hot / cold icons are a bit too similar perhaps?
  • How will we handle start / end date times for cumulative breaches - will it be the first datetime of the first excursion and the last datetime of the last excursion?
  • User will want to be able to sort by date and time together - i.e. they won't want to sort by date and then have a load of jumbled times, they'll want the times to be in the same order too. Can they easily do this?

@roxy-dao roxy-dao changed the title Monitoring -> Breach tab Add Breaches tab and breach list view in Monitoring page Sep 29, 2023
@roxy-dao roxy-dao added Priority: Must Have The product will not work without this and removed needs triage Priority: Should have labels Oct 2, 2023
@roxy-dao
Copy link
Contributor Author

roxy-dao commented Oct 2, 2023

Updated to Must have based on feedback from Craig

@DhanyaHerath DhanyaHerath added this to the V1.5.0 milestone Oct 3, 2023
@adamdewey
Copy link
Contributor

After meeting today:

  • Not doing comment field until we can acknowledge locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: coldchain Priority: Must Have The product will not work without this
Projects
None yet
Development

No branches or pull requests

3 participants