Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chart tab with sensor temperature chart in Monitoring page #2288

Closed
Tracked by #1955
roxy-dao opened this issue Sep 26, 2023 · 9 comments
Closed
Tracked by #1955

Add Chart tab with sensor temperature chart in Monitoring page #2288

roxy-dao opened this issue Sep 26, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request feature: coldchain needs architecture/solution Needs wider dev input on general solution Priority: Should have
Milestone

Comments

@roxy-dao
Copy link
Contributor

roxy-dao commented Sep 26, 2023

Describe the solution you'd like 🎁

  • Top
    • Chart of min/max threshold data from sensor
    • Colours will be associated with cards at the bottom
    • Hovering over lines will display a bubble with following information:
      • Sensor name and breach hot/cold icon
      • Location
      • Breach start
      • Breach end

Mock up:
Screenshot 2023-10-12 at 11 52 41

Estimate

2 days

Moneyworks Jobcode 🧰

OMS:COLC

@adamdewey
Copy link
Contributor

adamdewey commented Sep 26, 2023

Observations:

  • We're using the same icon here for 'malfunctioning' as we're using for 'unacknowledged' in the breaches tab - I think this could get confusing - suggest a different icon for each?
  • @richardmoizeau - did we decided to combine the graph and card views? I think I missed that... (I mean, if we can do it well then great! But 1 day seems a bit conservative to me.. 🤔)

@richardmoizeau
Copy link
Collaborator

  • We're using the same icon here for 'malfunctioning' as we're using for 'unacknowledged' in the breaches tab - I think this could get confusing - suggest a different icon for each?

yes, that's something that was brought up by @louisaw123 during the user testing so definitely to be discussed during the "final final design review"

@richardmoizeau - did we decided to combine the graph and card views? I think I missed that... (I mean, if we can do it well then great! But 1 day seems a bit conservative to me.. 🤔)

We are probably going to only focus on the charts but once again, to be decided in the same meeting as above. 1 day seems conservative even for charts only.

@roxy-dao roxy-dao changed the title Monitoring - chart tab Add Chart tab with sensor temperature chart and location cards in Monitoring page Sep 29, 2023
@DhanyaHerath DhanyaHerath added this to the V1.5.0 milestone Oct 3, 2023
@adamdewey
Copy link
Contributor

Comments from meeting today:

  • Cards are not for MVP
  • Only show icon for breaches, not excursions
  • Bubble to be shown when click on breach icon
  • Palette of 6 colours to be determined for sensor lines
  • Fixed axes of 0C to 10C with thresholds shown at 2C and 8C

Anything else @richardmoizeau , @mark-prins , @andreievg , @roxy-dao , @anisha-msupply ?

@richardmoizeau
Copy link
Collaborator

richardmoizeau commented Oct 4, 2023

following meeting on Oct 4th (Final Final Requirements):

  • Remove the cards (we only keep the chart)
  • boundaries of chart foccussed on 2-8°C (-/+ 2°C)
  • On the mockup, these are just sensor's names:
Screenshot 2023-10-04 at 1 07 59 PM
  • Click on a the breach icon (warning icon) and will show a popup/bubble that display details about the breach and a link to the breach view
  • colours for the charts lines: pre-defined set of colours (up 6 colours)
  • when hovering over a datapoint, see details (date, value, sensor name)

@roxy-dao roxy-dao changed the title Add Chart tab with sensor temperature chart and location cards in Monitoring page Add Chart tab with sensor temperature chart in Monitoring page Oct 11, 2023
@roxy-dao roxy-dao self-assigned this Oct 16, 2023
@roxy-dao roxy-dao added the needs architecture/solution Needs wider dev input on general solution label Oct 17, 2023
@roxy-dao roxy-dao removed their assignment Oct 18, 2023
@mark-prins
Copy link
Collaborator

Additional notes, after looking into the data aggregation currently implemented. Both mobile and CCA are plotting single sensors at a time only. The colouring of the lines can therefore be tied to temperature and there is more scope when adding breach icons.

CCA

  • y axis limits are the min and max temperatures +/- 5
  • x axis limits are simply the min / max timestamps
  • all data is plotted
  • no breach indication is shown
  • the line colour is a gradient showing red when in the top 40% of the plot region, which in the middle and blue in the lower 20%

IMAGE 2023-10-19 11:05:45

Mobile

  • y axis limits simply the max temp
  • x axis limits the min temp
  • the chart has a date range selection which defaults to the current day. For the given range, the chart shows a max of 30 data points, unless the range is a day or less (note: there's no time selection on the range, so less than a day isn't actually possible!) then it shows a max of 24 data points
  • the number of data points is the minimum of the value above (24 or 30) and the number of actual log entries
  • the max and min temperatures within the period are plotted; giving different lines for max and min values across the chart
  • all breaches within the range are plotted as clickable icons. the time value is the timestamp of the breach start time

mobile-line-chart-3

mobile-bar-chart-2

@adamdewey
Copy link
Contributor

adamdewey commented Oct 19, 2023

Anecdotally, I and several others, found the Mobile graphs hard to read.

The CCA graph is better but not really granular / big enough to be very useful.

Here are some examples of graphs that were on display in various places at the TechNet 2023 conference, I find them easy to read (also I find Grafana graphs easy to read)

2023-10-18_20-30-59 2023-10-18_20-31-45 image

@roxy-dao
Copy link
Contributor Author

Those graphs are all with just one sensor, no?

@louisaw123
Copy link

Those graphs are all with just one sensor, no?

yes looks like one sensor to me

@adamdewey
Copy link
Contributor

Yep, one sensor 👍

@mark-prins mark-prins self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: coldchain needs architecture/solution Needs wider dev input on general solution Priority: Should have
Projects
None yet
Development

No branches or pull requests

6 participants