Add a new "location" option #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eine
reviewed
Oct 28, 2021
There was a problem hiding this comment.
Overall, thanks a lot for proposing this enhancement. As commented in #167 (comment), I think this is a feature we need (at least for corner cases). See a couple of details in the comments below.
However, I am not convinced by the option being named path, because that might be confused with the PATH envvar and/or with option path-type. Instead, I would suggest an option named location, root or root-location.
eine
reviewed
Oct 28, 2021
eine
reviewed
Oct 28, 2021
|
@MehdiChinoune is this ready for review or are you expecting to push any additional change? |
No, Thanks |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a try.
I think you could improve it.