Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the checksum of the installer #36

Closed
lazka opened this issue Jun 30, 2020 · 4 comments
Closed

Verify the checksum of the installer #36

lazka opened this issue Jun 30, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@lazka
Copy link
Member

lazka commented Jun 30, 2020

Would be nice to have because you never know :)

There is an issue for downloadTool() already here, but no progress: actions/toolkit#427

@lazka lazka added the enhancement New feature or request label Jun 30, 2020
@eine
Copy link
Collaborator

eine commented Jun 30, 2020

I found two commands to compute the checksum on Windows:

  • CertUtil -hashfile FILE SHA256
  • Get-FileHash FILE -Algorithm SHA256 | Format-List -Property Hash

The output of the second one seems easier to parse and compare.

However, are checksums of the assets available anywhere apart from https://www.msys2.org/#installation-prerequisites?

@lazka
Copy link
Member Author

lazka commented Jul 1, 2020

However, are checksums of the assets available anywhere apart from https://www.msys2.org/#installation-prerequisites?

It doesn't really matter where you get them from (you can also use sha256sum locally), just hardcode them when you change the installer URL so everybody gets the same and the installer can't change unnoticed

@eine eine mentioned this issue Jul 4, 2020
@eine
Copy link
Collaborator

eine commented Jul 4, 2020

I added a basic check (05abb8d) in the latest release. Thanks to @Paebbels for the help with powershell syntax ;)

However, I'll leave this issue open because I want to enhance the code.

@eine eine closed this as completed Jul 5, 2020
@lazka
Copy link
Member Author

lazka commented Jul 6, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants