From 9314fc0097b092e015e94f2cea7aad3980b9d7a6 Mon Sep 17 00:00:00 2001
From: julia-pfarr <pfarr@staff.uni-marburg.de>
Date: Thu, 5 Oct 2023 17:43:32 +0200
Subject: [PATCH] Changes for metadata

- change DataType from number to array of arrays for AverageCalibrationError and MaximalCalibrationError
- delete CalibrationList from metadata.yaml and eyetrack.yaml as it only contains dublicates of other metadata and thus not needed
- fix typo in metadata.yaml: CalibrationCount was wrongly named "CalibrationType" so CalibrationType was listed twice
---
 src/schema/objects/metadata.yaml        | 19 ++++---------------
 src/schema/rules/sidecars/eyetrack.yaml |  1 -
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/src/schema/objects/metadata.yaml b/src/schema/objects/metadata.yaml
index fffaf36c40..c182281dca 100644
--- a/src/schema/objects/metadata.yaml
+++ b/src/schema/objects/metadata.yaml
@@ -208,7 +208,7 @@ AverageCalibrationError:
   display_name: Average Calibration Error
   description: |
     Average calibration error in visual degree.
-  type: number
+  type: array of arrays
   unit: degree
 B0FieldIdentifier:
   name: B0FieldIdentifier
@@ -371,23 +371,12 @@ BrainLocation:
     which can also tie up with laminar fMRI.
   type: string
 CalibrationCount:
-  name: CalibrationType
-  display_name: Calibration Type
+  name: CalibrationCount
+  display_name: Calibration Count
   description: |
     Provide here the number of calibration performed per run.
   type: number
   minimum: 0
-CalibrationList:
-  name: CalibrationList
-  display_name: Calibration List
-  description: |
-    List of lists including information for each calibration.
-    This list includes the calibration type, recorded eye,
-    maximal calibration error, average calibration error,
-    and time relative to the first event of the event file.
-  type: array
-  items:
-    type: array
 CalibrationPosition:
   name: CalibrationPosition
   display_name: Calibration Position
@@ -2086,7 +2075,7 @@ MaximalCalibrationError:
   display_name: Maximal Calibration Error
   description: |
     Maximal calibration error in degree.
-  type: number
+  type: array of arrays
   unit: degree
 MeasurementToolMetadata:
   name: MeasurementToolMetadata
diff --git a/src/schema/rules/sidecars/eyetrack.yaml b/src/schema/rules/sidecars/eyetrack.yaml
index 5e7fdaf5d1..0bc2730ed9 100644
--- a/src/schema/rules/sidecars/eyetrack.yaml
+++ b/src/schema/rules/sidecars/eyetrack.yaml
@@ -31,7 +31,6 @@ EyeTrackingRecommended:
   fields:
     AverageCalibrationError: recommended
     CalibrationCount: recommended
-    CalibrationList: recommended
     CalibrationPosition: recommended
     CalibrationType: recommended
     CalibrationUnit: recommended