Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destructor to wait for process termination #322

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Add destructor to wait for process termination #322

merged 1 commit into from
Apr 15, 2022

Conversation

masayukig
Copy link
Collaborator

This commit adds a destructor to wait for a process termination in
ReturnCodeToSubunit class. This commit fixes #320 partially.

@masayukig
Add destructor to wait for process termination
da0a011 
This commit adds a destructor to wait for a process termination in
`ReturnCodeToSubunit` class. This commit fixes mtreinish#320 partially.
mtreinish
mtreinish approved these changes Apr 15, 2022
View reviewed changes
Copy link
Owner

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I don't think __del__ gets called in all situations but when it does having it wait for the Popen objects to terminate definitely seems like the right behavior.

@mtreinish mtreinish merged commit c086f2b into mtreinish:main Apr 15, 2022
@mtreinish mtreinish mentioned this pull request Apr 15, 2022
Open
@masayukig masayukig deleted the fix-320 branch April 18, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResourceWarning messages being printed
2 participants
@masayukig @mtreinish