Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos build broken #72

Closed
teutat3s opened this issue Feb 12, 2022 · 2 comments · Fixed by #73
Closed

illumos build broken #72

teutat3s opened this issue Feb 12, 2022 · 2 comments · Fixed by #73
Labels
bug Something isn't working

Comments

@teutat3s
Copy link

teutat3s commented Feb 12, 2022

Hello
thank you for working on this!

It seems 5ac8409 broke building this on illumos. To reproduce (latest pkgsrc-trunk, go117):

go install github.com/minio/mc@latest
...
go/pkg/mod/github.com/muesli/termenv@v0.11.1-0.20220204035834-5ac8409525e0/termenv_unix.go:27:29: multiple-value unix.Getpgrp() in single-value context

Sadly I'm not well-versed enough with go's unix std lib to say what special handling illumos would need to fix this.

EDIT:
just to confirm, when downgrading to a commit before this change it builds fine with:

git clone https://github.com/minio/mc
cd mc
go get github.com/muesli/termenv@afdc360daa456985264728b9de86992f20965e80
go build .
@muesli muesli added the bug Something isn't working label Feb 12, 2022
@muesli
Copy link
Owner

muesli commented Feb 12, 2022

Thanks for the heads up! Fixing.

@teutat3s
Copy link
Author

Wow that was fast, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants