-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: rename button variants to follow the spec #11284
Comments
@mbrookes I'm not 💯% up-to-date with the latest improvements you did on this topic. Have we moved forward? At least, I know we gonna have to deprecate and remove the API at some point. |
What about unelevated as well? see: |
@gunn4r Can you find it in the official specificiation? |
@oliviertassinari But you do find it in their official Design and API documentation: As well as their official button demo here: |
I suggest we stick with the spec names, rather than what the MCW team are using. |
Legacy variant names will be deprecated with 3.2.0 i.e. deprecation warnings will be logged. The |
Material Guidelines changed the name of buttons’ variants. I’m proposing to update the variants name to follow the spec and implement those that are missing.
The rosetta stone is:
variant="flat"
variant="text"
variant="outlined
variant="raised"
variant="contained"
toggled variant="outlined"
I’m not proposing a specific variant for Toggle Buttons because demos present them as button bars (hence could be a good idea have a specific component) where they are mostly outlined buttons with an additional toggled state, or Icon Buttons with different icons based on the state.
The text was updated successfully, but these errors were encountered: