Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createMuiTheme to @material-ui/core/createMuiTheme #14247

Closed
2 tasks done
jgoux opened this issue Jan 19, 2019 · 4 comments
Closed
2 tasks done

Move createMuiTheme to @material-ui/core/createMuiTheme #14247

jgoux opened this issue Jan 19, 2019 · 4 comments
Milestone

Comments

@jgoux
Copy link
Contributor

jgoux commented Jan 19, 2019

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Hello,

I think it would make more sense to have createMuiTheme in the @material-ui/styles package, along with the ThemeProvider component.

Also, why not rename it createTheme? The Mui part is kind of implied with the @material-ui organization.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 19, 2019

@material-ui/styles has no links with the Material-UI core components, it's raw styling solution, like another, styled-components, emotion, aphrodite, radium, etc. I think that we will do it the other way around. People imports won't change once v4 is released.

@jgoux
Copy link
Contributor Author

jgoux commented Jan 19, 2019

The other way around is great too, my point was to be able to import both createMuiTheme and ThemeProvider from the same package. 😸

What about the renaming createMuiTheme -> createTheme?

@oliviertassinari
Copy link
Member

@jgoux We are going with the following change:

-import { createMuiTheme } from '@material-ui/core/styles';
+import createMuiTheme from '@material-ui/core/createMuiTheme'

The discussing started in #14852 (comment).

@oliviertassinari oliviertassinari changed the title Move createMuiTheme to @material-ui/styles Move createMuiTheme to @material-ui/core/createMuiTheme Mar 13, 2019
@oliviertassinari
Copy link
Member

I'm giving up on this task. I'm not 💯% sure the change worth the breaking change. I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants