Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Warn when the first argument is wrong #11953

Merged
merged 1 commit into from
Jun 22, 2018
Merged

[styles] Warn when the first argument is wrong #11953

merged 1 commit into from
Jun 22, 2018

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 22, 2018 •
edited
Loading

Today at work, I noticed that the following condition doesn't raise any warning, while incorrect.

export default withStyles()(SimpleAppBar);

It's fixed:

capture d ecran 2018-06-23 a 00 49 40

@oliviertassinari oliviertassinari added the new feature New feature or request label Jun 22, 2018
@oliviertassinari oliviertassinari merged commit 2386655 into mui:master Jun 22, 2018
@oliviertassinari oliviertassinari deleted the with-style-warning-missing-argument branch June 22, 2018 23:00
acroyear pushed a commit to acroyear/material-ui that referenced this pull request Jul 14, 2018
@oliviertassinari
[styles] Warn when the first argument is wrong (mui#11953)
4fccd32
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oliviertassinari