-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add known issues/limitations for progress animations #12062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
requested changes
Jul 5, 2018
|
||
## Limitations / Known issues | ||
|
||
Under heavy load/rendering, you might lose the stroke dash animation or see random CircularProgress ring widths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just "Under heavy load" is fine ("heavy rendering" sounds odd)
## Limitations / Known issues | ||
|
||
Under heavy load/rendering, you might lose the stroke dash animation or see random CircularProgress ring widths. | ||
You should run scripting intensive operations in a web worker or by batch in order not to block the main rendering thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"processor intensive"?
oliviertassinari
changed the title
doc: Add known issues/limitations for progress animations
[docs] Add known issues/limitations for progress animations
Jul 5, 2018
mbrookes
approved these changes
Jul 5, 2018
oliviertassinari
approved these changes
Jul 5, 2018
mbrookes
approved these changes
Jul 5, 2018
acroyear
pushed a commit
to acroyear/material-ui
that referenced
this pull request
Jul 14, 2018
This was referenced Mar 26, 2020
oliviertassinari
added
the
component: progress
This is the name of the generic UI component, not the React module!
label
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: CircularProgress
The React component
component: progress
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12061