-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chip] Add color prop to chip component #12378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
[Chip]: add color prop to chip component
[Chip] Add color prop to chip component
Aug 2, 2018
oliviertassinari
added
new feature
New feature or request
component: chip
This is the name of the generic UI component, not the React module!
labels
Aug 2, 2018
oliviertassinari
force-pushed
the
master
branch
3 times, most recently
from
August 2, 2018 21:08
ca31616
to
ccc2dbf
Compare
oliviertassinari
force-pushed
the
master
branch
from
August 2, 2018 21:23
134eb77
to
343d90c
Compare
@itelo Great job! |
Sweet! |
@itelo You have missed the |
@IvanCoronado Do you want to submit a pull request to add them? |
@oliviertassinari Done #12625 👍 |
How would you remove the color in js, because its not found when you search hasAttribute |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: chip
This is the name of the generic UI component, not the React module!
new feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12370