[icons] Remove clip-path from all icons #12452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
oliviertassinari
changed the title
|
I confirm, it looks all right
|
oliviertassinari
added
bug 🐛
mbrookes
reviewed
Aug 9, 2018
| @@ -2,5 +2,5 @@ import React from 'react'; | |||
| import createSvgIcon from './utils/createSvgIcon'; | |||
|
|
|||
| export default createSvgIcon( | |||
| <React.Fragment><defs><path id="a" d="M24 24H0V0h24v24z" /></defs><clipPath id="b"><use overflow="visible" xlinkHref="#a" /></clipPath><path d="M3 4V1h2v3h3v2H5v3H3V6H0V4h3zm3 6V7h3V4h7l1.83 2H21c1.1 0 2 .9 2 2v12c0 1.1-.9 2-2 2H5c-1.1 0-2-.9-2-2V10h3zm7 9c2.76 0 5-2.24 5-5s-2.24-5-5-5-5 2.24-5 5 2.24 5 5 5zm-3.2-5c0 1.77 1.43 3.2 3.2 3.2s3.2-1.43 3.2-3.2-1.43-3.2-3.2-3.2-3.2 1.43-3.2 3.2z" clipPath="url(#b)" /></React.Fragment> | |||
| <React.Fragment><defs><path id="a" d="M24 24H0V0h24v24z" /></defs><clipPath id="b"><use overflow="visible" xlinkHref="#a" /></clipPath><path d="M3 4V1h2v3h3v2H5v3H3V6H0V4h3zm3 6V7h3V4h7l1.83 2H21c1.1 0 2 .9 2 2v12c0 1.1-.9 2-2 2H5c-1.1 0-2-.9-2-2V10h3zm7 9c2.76 0 5-2.24 5-5s-2.24-5-5-5-5 2.24-5 5 2.24 5 5 5zm-3.2-5c0 1.77 1.43 3.2 3.2 3.2s3.2-1.43 3.2-3.2-1.43-3.2-3.2-3.2-3.2 1.43-3.2 3.2z" /></React.Fragment> | |||
There was a problem hiding this comment.
Could the clipPath definition also be removed?
There was a problem hiding this comment.
<use overflow="visible" xlinkHref="#a" /> might prevent it. I know I couldn't remove all this crap at once. I have tried in the past. It was breaking some icons.
Given how paintful it's to iterate on the script that generates the icons 2min+ for each iteration. I would say, let's look into it in another pull request.
There was a problem hiding this comment.
@kevinnorris If you have some time, it would be great to explore @mbrookes suggestion :).
|
@kevinnorris It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 50 icons affected.
Before clip-path was removed:
After clip-path was removed:
Closes #12441