[Popover] Allow to pass repeated props to modal #12459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It's not the first time we face such issue. We have been using the following solution in the past:
https://github.com/mui-org/material-ui/blob/a207808404a703d1ea2b03ac510343be6404b166/packages/material-ui/src/InputLabel/InputLabel.js#L113-L116
What do you think about it? Do you want to update the pull request?
oliviertassinari
added
the
PR: needs revision
|
PR updated. |
davibq
force-pushed
the
popover-modalprops
branch
from
83b1a24 to
db624ee
Compare
oliviertassinari
added
new feature
oliviertassinari
approved these changes
Aug 10, 2018
|
@davibq It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to pass repeated props to modal. For example, it's impossible to pass the
classesprop to the modal.