-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve Next.js usage #19075
[docs] Improve Next.js usage #19075
Conversation
Details of bundle changes.Comparing: 4b6cbf0...0b0c2ac
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to minimize the changes and maximize consistency. Does it still match your expectations?
@chrisweb Thank you for raising these problems :) |
@oliviertassinari ah yes I see, you decided to not move the theme color and font, I thought about that, but decided to move it all as a) I thought maybe it is better to have all meta tags in one place b) it avoids having to check which ones will create duplicates and which ones not but I'm totally fine with your changes, it is different but for sure it is not wrong I hadn't seen that one, thx for sharing, will check out eps1lon efforts, maybe there is something I can contribute ;) you welcome, thx for merging |
@chrisweb I think that the more we have in _document, the faster runtime, the better. |
should fix #19074
Note that I also removed altogether, as it is added by default: vercel/next.js#237