-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Batch small changes #19097
Merged
oliviertassinari
merged 15 commits into
mui:master
from
oliviertassinari:batch-small-changes-v20
Jan 8, 2020
Merged
[core] Batch small changes #19097
oliviertassinari
merged 15 commits into
mui:master
from
oliviertassinari:batch-small-changes-v20
Jan 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Jan 5, 2020
•
edited
Loading
edited
- [docs] Improve mobile display 4410744: fix a couple of scrolling issue noticed browsing the demos on my phone
- [docs] Remove shrink-to-fit a28f72f: it seems to be a legacy option now: https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html.
- [docs] Improve code preview coverage 8754890: code previews are awesome
- [docs] Fix TOCs open in new tab 4998a2b: closes [Docs] wrong url when cmd+click on right side navigation #18756
- [docs] Fix Wave false-positive 3ca11ec: Wave reports links with a missing label. I suspect it's a false-positive, but better be safe and avoid the errors to hide real ones.
- [theme] Update breakpoints.between type 4bc5a1f: thanks @merceyz for the report in [theme] Support breakpoints.between(a, b) with number #19003 (comment).
- [Alert] Experiment with CODEOWNERS 368816a: as discussed in [Alert] Introduce new component #18702 (comment) with @dimitropoulos.
- [docs] Throw if missing style rule description 09bd68c: we have such logic for the description of the props.
- [docs] Avoid large card on Twitter a0d8507: the different types of cards are detailed in https://www.oncrawl.com/oncrawl-seo-thoughts/a-complete-guide-to-twitter-cards/. Because we only have a non-contextual image to show, I believe the small card should be preferred over the large one.
- [Alert] Add a note about Material Design b132cd2: a concern was raised in https://twitter.com/DJNewStyle/status/1214191575733014529.
oliviertassinari
added
the
umbrella
For grouping multiple issues to provide a holistic view
label
Jan 5, 2020
Details of bundle changes.Comparing: d0c928c...6ae17ad
|
oliviertassinari
force-pushed
the
batch-small-changes-v20
branch
from
January 6, 2020 15:53
42cebad
to
9171595
Compare
mbrookes
reviewed
Jan 6, 2020
Co-Authored-By: Matt <github@nospam.33m.co>
mbrookes
approved these changes
Jan 6, 2020
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.