[core] Use node 10 in every CI/CD pipeline #19301
Conversation
|
No bundle size changes comparing bfe04ce...6f21469 |
Reduce jargon and make exact node version used visible
|
Should it impact the minimum version of node we support? In the documentation, we mention the LTS: https://material-ui.com/getting-started/supported-platforms/#server. Does it mean we can bump the min version from 8 to 10 without considering it a breaking change? |
I wouldn't do that since we support "node 8" not "node active maintenance". I wouldn't use supported versions that change during the lifetime of a release e.g. I'll add a note to the docs in this PR about node 8 having reached end of life and that we don't use this environment. node 8 support is basically on the level of ie 11 support: bug reports do get addressed but we don't run automated tests on that environment. |
I was under the assumption that the support is not bound to a specific version. The oldest LTS in maintenance is v10 now. |
-- https://material-ui.com/getting-started/supported-platforms/#supported-platforms It's quite ambiguous. Still the usual applies:
|
|
Ok, I have added a note in the v5 breaking change list, so we clear that up. |
Dependencies are starting to bump their required node version (#19187 and #19299) since 8.x has reached its end of life. 10.x is now active LTS. We still officially support 8.x but to keep our test environment fast and safe we're switching to 10.x as should everybody else. If we start seeing regressions due to features being released that require 10.x we need to rethink our testing environment.
Azure pipeline was already using node 10. Netlify is controlled via environment variables.