Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add new starting template #19604

Merged
merged 9 commits into from
Feb 7, 2020
Merged

[docs] Add new starting template #19604

merged 9 commits into from
Feb 7, 2020

Conversation

dunky11
Copy link
Contributor

@dunky11 dunky11 commented Feb 7, 2020 •
edited
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 7, 2020 •
edited
Loading

No bundle size changes comparing 0db2675...42d88b0

Generated by 🚫 dangerJS against 42d88b0

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 7, 2020 •
edited
Loading

@dunky11 Thank you for sharing :). I'm not sure about this one, are least in the showcase.
We try to include applications actually used by end-users that can be taken as inspiration by developers. cc @mbrookes

@mbrookes
Copy link
Member

mbrookes commented Feb 7, 2020

Perhaps here: https://material-ui.com/getting-started/example-projects/#more-advanced-example-projects ?

@dunky11
Copy link
Contributor Author

dunky11 commented Feb 7, 2020

I would be fine with that... Shall i make another pull request?

@oliviertassinari
Copy link
Member

Sounds great. If you can udpate this pull request, it's perfect (with a link to the GitHub repository).

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 7, 2020
@dunky11
Copy link
Contributor Author

dunky11 commented Feb 7, 2020

Okay, thanks :) I reverted the changes and updated the markdown.

@mbrookes
Copy link
Member

mbrookes commented Feb 7, 2020

@dunky11 Thanks. Looks good so far. No need to add it to the translations though – Crowdin will take care of that automatically. Could you revert those changes?

@dunky11
Copy link
Contributor Author

dunky11 commented Feb 7, 2020

Ah yes, of course.

@oliviertassinari oliviertassinari changed the title [docs] Add website to showcase [docs] Add new starting template Feb 7, 2020
@oliviertassinari oliviertassinari merged commit 4635615 into mui:master Feb 7, 2020
@oliviertassinari
Copy link
Member

Thanks

EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Feb 13, 2020
@dunky11 @EsoterikStare
[docs] Add new starting template (mui#19604)
3dbd9e4
This was referenced Mar 10, 2020
Merged
Merged
Merged
Closed
Closed
Closed
This was referenced Mar 21, 2020
Merged
Open
This was referenced Apr 16, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunky11 @mui-pr-bot @oliviertassinari @mbrookes