Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SwipeableDrawer] Support global theme changes #19771

Merged
merged 5 commits into from
Feb 19, 2020
Merged

[SwipeableDrawer] Support global theme changes #19771

merged 5 commits into from
Feb 19, 2020

Conversation

TommyJackson85
Copy link
Contributor

@TommyJackson85 TommyJackson85 commented Feb 18, 2020 •
edited
Loading

Attempting to allow the inclusion of Global Theme Changes for Swipeable Drawer, as brought up by @oliviertassinari in issue #19660

These potential changes could also potentially fix issue:
#19606

I will continue to keep editing this initially post, when updates occur.

Closes #19660

@TommyJackson85 TommyJackson85 changed the title fix: issue #19660: Global Theme Changes For Swipeable Drawer [SwipeableDrawer] Global Theme Changes For Swipeable Drawer Feb 18, 2020
@oliviertassinari oliviertassinari added component: SwipeableDrawer The React component. new feature New feature or request PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 18, 2020
@TommyJackson85 @oliviertassinari
Update packages/material-ui/src/SwipeableDrawer/SwipeableDrawer.js
de52b9c 
Removing extra dot

Co-Authored-By: Olivier Tassinari <olivier.tassinari@gmail.com>
@TommyJackson85
Copy link
Contributor Author

TommyJackson85 commented Feb 18, 2020 •
edited
Loading

yarn lint:ci is reporting multiple errors. Fixed repeated declaration errors where useThemes and themes were called twice each. Check

there is 6 other errors unfixed:
cross-fetch is repeated 4 times -

/Users/thomasjackson/Desktop/Software projects/Open Source Projects/mui-org/material-ui/docs/src/pages/components/autocomplete/Asynchronous.js
  2:19  error  Unable to resolve path to module 'cross-fetch'  import/no-unresolved

/Users/thomasjackson/Desktop/Software projects/Open Source Projects/mui-org/material-ui/packages/material-ui-lab/src/Pagination/usePagination.test.js
  1:28  error  Unable to resolve path to module '@testing-library/react-hooks'  import/no-unresolved

/Users/thomasjackson/Desktop/Software projects/Open Source Projects/mui-org/material-ui/packages/material-ui/scripts/rollup.config.js
  4:21  error  Unable to resolve path to module '@rollup/plugin-replace'  import/no-unresolved

@TommyJackson85
removed inital declaration of usedThemes from the style sheets so the…
a5e8e73 
… new version is working. Removed second calling of theme, in which refers to useThemes.
@TommyJackson85 TommyJackson85 force-pushed the global-theme-changes-for-swipeable-drawer branch from de52b9c to a5e8e73 Compare February 18, 2020 22:01
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 18, 2020 •
edited
Loading

Details of bundle changes.

Comparing: 7a24f67...4801288

bundle Size Change Size Gzip Change Gzip
docs.main ▲ +92 B (+0.02% ) 604 kB ▼ -10 B (-0.01% ) 196 kB
SwipeableDrawer ▲ +89 B (+0.10% ) 92.6 kB ▲ +83 B (+0.29% ) 28.9 kB
@material-ui/core ▲ +89 B (+0.02% ) 362 kB ▲ +77 B (+0.08% ) 98.9 kB
@material-ui/core[umd] ▲ +56 B (+0.02% ) 318 kB ▲ +55 B (+0.06% ) 92 kB
@material-ui/lab -- 194 kB -- 57.2 kB
@material-ui/styles -- 51.4 kB -- 15.4 kB
@material-ui/system -- 16.5 kB -- 4.32 kB
Alert -- 83.8 kB -- 26.3 kB
AlertTitle -- 64.5 kB -- 20.3 kB
AppBar -- 64.4 kB -- 20.2 kB
Autocomplete -- 132 kB -- 41.4 kB
Avatar -- 65.6 kB -- 20.7 kB
AvatarGroup -- 62.6 kB -- 19.7 kB
Backdrop -- 68.2 kB -- 21.1 kB
Badge -- 65.7 kB -- 20.4 kB
BottomNavigation -- 62.7 kB -- 19.7 kB
BottomNavigationAction -- 75.9 kB -- 24 kB
Box -- 72.2 kB -- 21.9 kB
Breadcrumbs -- 68.1 kB -- 21.4 kB
Button -- 80.1 kB -- 24.5 kB
ButtonBase -- 74.4 kB -- 23.3 kB
ButtonGroup -- 83.6 kB -- 25.6 kB
Card -- 63.2 kB -- 19.8 kB
CardActionArea -- 75.5 kB -- 23.8 kB
CardActions -- 62.4 kB -- 19.6 kB
CardContent -- 62.3 kB -- 19.5 kB
CardHeader -- 65.4 kB -- 20.6 kB
CardMedia -- 62.7 kB -- 19.7 kB
Checkbox -- 83.4 kB -- 26.3 kB
Chip -- 83 kB -- 25.4 kB
CircularProgress -- 64.4 kB -- 20.3 kB
ClickAwayListener -- 3.91 kB -- 1.55 kB
Collapse -- 68.4 kB -- 21.2 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 63.5 kB -- 19.9 kB
CssBaseline -- 62.3 kB -- 19.6 kB
Dialog -- 83.4 kB -- 26 kB
DialogActions -- 62.4 kB -- 19.6 kB
DialogContent -- 62.6 kB -- 19.6 kB
DialogContentText -- 64.4 kB -- 20.2 kB
DialogTitle -- 64.6 kB -- 20.3 kB
Divider -- 63 kB -- 19.8 kB
docs.landing -- 56.8 kB -- 15.6 kB
Drawer -- 85.2 kB -- 25.9 kB
ExpansionPanel -- 72.7 kB -- 22.7 kB
ExpansionPanelActions -- 62.4 kB -- 19.6 kB
ExpansionPanelDetails -- 62.3 kB -- 19.5 kB
ExpansionPanelSummary -- 78.5 kB -- 24.8 kB
Fab -- 77.2 kB -- 24.1 kB
Fade -- 23.6 kB -- 8.01 kB
FilledInput -- 73.9 kB -- 23 kB
FormControl -- 64.8 kB -- 20.2 kB
FormControlLabel -- 65.9 kB -- 20.6 kB
FormGroup -- 62.3 kB -- 19.6 kB
FormHelperText -- 63.7 kB -- 20 kB
FormLabel -- 63.8 kB -- 19.8 kB
Grid -- 65.4 kB -- 20.5 kB
GridList -- 62.8 kB -- 19.7 kB
GridListTile -- 64.1 kB -- 20.1 kB
GridListTileBar -- 63.6 kB -- 19.9 kB
Grow -- 24.2 kB -- 8.22 kB
Hidden -- 66.3 kB -- 20.8 kB
Icon -- 63.1 kB -- 19.8 kB
IconButton -- 76.5 kB -- 23.9 kB
Input -- 72.9 kB -- 22.8 kB
InputAdornment -- 65.4 kB -- 20.6 kB
InputBase -- 71 kB -- 22.3 kB
InputLabel -- 65.7 kB -- 20.5 kB
LinearProgress -- 65.7 kB -- 20.5 kB
Link -- 67 kB -- 21.1 kB
List -- 62.7 kB -- 19.6 kB
ListItem -- 77.5 kB -- 24.2 kB
ListItemAvatar -- 62.5 kB -- 19.5 kB
ListItemIcon -- 62.5 kB -- 19.6 kB
ListItemSecondaryAction -- 62.3 kB -- 19.5 kB
ListItemText -- 65.3 kB -- 20.5 kB
ListSubheader -- 63.1 kB -- 19.8 kB
Menu -- 89.1 kB -- 27.4 kB
MenuItem -- 78.6 kB -- 24.5 kB
MenuList -- 66.4 kB -- 20.8 kB
MobileStepper -- 68.2 kB -- 21.4 kB
Modal -- 14.5 kB -- 5.04 kB
NativeSelect -- 77.2 kB -- 24.3 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 74.9 kB -- 23.3 kB
Pagination -- 85.5 kB -- 26.3 kB
PaginationItem -- 81.2 kB -- 25 kB
Paper -- 62.7 kB -- 19.6 kB
Popover -- 83.5 kB -- 25.8 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.92 kB -- 1.3 kB
Radio -- 84.4 kB -- 26.6 kB
RadioGroup -- 64.8 kB -- 20.1 kB
Rating -- 70.8 kB -- 22.8 kB
RootRef -- 4.24 kB -- 1.64 kB
ScopedCssBaseline -- 63.2 kB -- 19.9 kB
Select -- 117 kB -- 34.6 kB
Skeleton -- 63.3 kB -- 20 kB
Slide -- 25.7 kB -- 8.74 kB
Slider -- 77 kB -- 24.2 kB
Snackbar -- 75.7 kB -- 23.7 kB
SnackbarContent -- 63.9 kB -- 20.1 kB
SpeedDial -- 86.6 kB -- 27.3 kB
SpeedDialAction -- 119 kB -- 37.6 kB
SpeedDialIcon -- 64.9 kB -- 20.3 kB
Step -- 63 kB -- 19.8 kB
StepButton -- 82.7 kB -- 26.2 kB
StepConnector -- 63.1 kB -- 19.9 kB
StepContent -- 69.5 kB -- 21.8 kB
StepIcon -- 65 kB -- 20.3 kB
StepLabel -- 69 kB -- 21.7 kB
Stepper -- 65.2 kB -- 20.6 kB
styles/createMuiTheme -- 16.6 kB -- 5.85 kB
SvgIcon -- 63.4 kB -- 19.8 kB
Switch -- 82.5 kB -- 26 kB
Tab -- 76.7 kB -- 24.3 kB
Table -- 62.9 kB -- 19.7 kB
TableBody -- 62.4 kB -- 19.5 kB
TableCell -- 64.4 kB -- 20.3 kB
TableContainer -- 62.3 kB -- 19.5 kB
TableFooter -- 62.5 kB -- 19.5 kB
TableHead -- 62.4 kB -- 19.5 kB
TablePagination -- 144 kB -- 42 kB
TableRow -- 62.8 kB -- 19.7 kB
TableSortLabel -- 77.8 kB -- 24.4 kB
Tabs -- 85.8 kB -- 27.2 kB
TextareaAutosize -- 5.12 kB -- 2.14 kB
TextField -- 126 kB -- 36.6 kB
ToggleButton -- 76.5 kB -- 24.2 kB
ToggleButtonGroup -- 63.5 kB -- 20 kB
Toolbar -- 62.7 kB -- 19.7 kB
Tooltip -- 103 kB -- 32.4 kB
TreeItem -- 74.3 kB -- 23.5 kB
TreeView -- 67 kB -- 21.1 kB
Typography -- 64 kB -- 20 kB
useAutocomplete -- 14.7 kB -- 5.31 kB
useMediaQuery -- 2.58 kB -- 1.06 kB
Zoom -- 23.6 kB -- 8.12 kB

Generated by 🚫 dangerJS against 4801288

@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 18, 2020
@oliviertassinari oliviertassinari changed the title [SwipeableDrawer] Global Theme Changes For Swipeable Drawer [SwipeableDrawer] Support global theme changes Feb 18, 2020
@TommyJackson85
Copy link
Contributor Author

@oliviertassinari I am still getting the 6 mentioned above errors when running yarn lint:ci
Maybe check it yourself. Not sure if it's unsafe.

@oliviertassinari
Copy link
Member

@TommyJackson85 I have just configured a new computer, it's exit 0 on my side (we are good). The Ci is the baseline, you can trust it. If it exit 1 on your env, then something is wrong with it.

@TommyJackson85
Copy link
Contributor Author

@TommyJackson85 I have just configured a new computer, it's exit 0 on my side (we are good). The Ci is the baseline, you can trust it. If it exit 1 on your env, then something is wrong with it.

hmmm, is it something I should worry about? I am calling fetch and pull from the master branch regularly.

@oliviertassinari oliviertassinari merged commit 78b4490 into mui:master Feb 19, 2020
@oliviertassinari
Copy link
Member

@TommyJackson85 Thanks

This was referenced Mar 10, 2020
Merged
Closed
Open
This was referenced Mar 21, 2020
Merged
Open
Closed
This was referenced Apr 16, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
@oliviertassinari oliviertassinari added the component: drawer This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Questions on SwipeAreaProps (How to use them).
3 participants
@TommyJackson85 @mui-pr-bot @oliviertassinari