-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooltip] Reduce enterDelay to 100ms #19898
Merged
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:tooltip-reduce-enter-delay
Mar 1, 2020
Merged
[Tooltip] Reduce enterDelay to 100ms #19898
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:tooltip-reduce-enter-delay
Mar 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: tooltip
This is the name of the generic UI component, not the React module!
label
Feb 29, 2020
Details of bundle changes.Comparing: b9dec27...32b26f4
|
oliviertassinari
force-pushed
the
tooltip-reduce-enter-delay
branch
from
February 29, 2020 17:14
458cac8
to
32b26f4
Compare
eps1lon
approved these changes
Mar 1, 2020
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is first to reduce the impact of the initial change from 0ms to 200ms. The second motivation is to match Ant Design and the feeling I get from the Material Design specification. I initially didn't take the delay JS runtime (React) and the animation introduces into showing the tooltip.