[docs] Track bundle size of pages #19978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: cfb2dc2...5531b59 Details of page changes
|
|
@eps1lon Did you notice a change in the time required to run the snapshots? Do you envision a future where we would want to prioritize the optimization of the bundle size of a specific page of the documentation? |
No.
We already do for the landing page. We will if we consider switching to a full esm build or modules/nomodules or mdx. Since we never did track page size it's impossible to know if we do want to optimize a specific page. Unless you consider premature optimization. Also keep in mind that tracking a value is not only to optimize that value. It goes both ways. |
eps1lon
force-pushed
the
docs/page-tracking
branch
from
76e0610 to
ae50944
Compare
|
Let's get this just for the sake of having a direct deploy preview link. We even got a two state exit plane: Don't display it in the pr comment; roll back completely. |
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back page tracking of #16546.
Page tracking is done in a nested
<details />where each row includes the linked to the deployed page (deploy-preview).