-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pagination] Remove children prop #19987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mbrookes
commented
Mar 4, 2020
- I have followed (at least) the PR section of the contributing guide.
mbrookes
added
the
component: pagination
This is the name of the generic UI component, not the React module!
label
Mar 4, 2020
Details of bundle changes.Comparing: daa0eff...c2f5127 Details of page changes
|
@eps1lon Sorry, missed that one of the tests you added is using children... What's the best alternative? |
I think that one was about bubbling events? We can remove it. I don't think there's any meaningful test to check that onChange isn't passed to the |
mbrookes
force-pushed
the
pagination-remove-children
branch
from
March 5, 2020 00:38
9019f16
to
1d8a002
Compare
mbrookes
force-pushed
the
pagination-remove-children
branch
from
March 5, 2020 01:01
1d8a002
to
a5e9841
Compare
oliviertassinari
changed the title
[pagination] Remove children prop
[Pagination] Remove children prop
Mar 6, 2020
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.