-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ListItemText] Fix display block issue #20039
Merged
oliviertassinari
merged 1 commit into
mui:master
from
psdr03:Issue-19943-ListItemText-with-primary,-secondary,-secondaryTypographyProps-does-not-display-correctly
Mar 8, 2020
Merged
[ListItemText] Fix display block issue #20039
oliviertassinari
merged 1 commit into
mui:master
from
psdr03:Issue-19943-ListItemText-with-primary,-secondary,-secondaryTypographyProps-does-not-display-correctly
Mar 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ListItemText with secondaryTypographyProps rendering on same line as primary.
Details of bundle changes.Comparing: be35a77...32db727 Details of page changes
|
oliviertassinari
approved these changes
Mar 8, 2020
joshwooding
approved these changes
Mar 8, 2020
oliviertassinari
changed the title
[ListItemText] Add display block to ListItemText Component
import React from 'react'; import { makeStyles } from '@material-ui/core/styles'; import List from '@material-ui/core/List'; import ListItem from '@material-ui/core/ListItem'; import ListItemIcon from '@material-ui/core/ListItemIcon'; import ListItemText from '@material-ui/core/ListItemText'; import Divider from '@material-ui/core/Divider'; import InboxIcon from '@material-ui/icons/Inbox'; import DraftsIcon from '@material-ui/icons/Drafts';
Mar 8, 2020
oliviertassinari
changed the title
import React from 'react'; import { makeStyles } from '@material-ui/core/styles'; import List from '@material-ui/core/List'; import ListItem from '@material-ui/core/ListItem'; import ListItemIcon from '@material-ui/core/ListItemIcon'; import ListItemText from '@material-ui/core/ListItemText'; import Divider from '@material-ui/core/Divider'; import InboxIcon from '@material-ui/icons/Inbox'; import DraftsIcon from '@material-ui/icons/Drafts';
[ListItemText] Fix display block issue
Mar 8, 2020
@psdr03 Thanks for a great first contribution to Material-UI 😄 🎉 |
oliviertassinari
added
component: list
This is the name of the generic UI component, not the React module!
and removed
component: ListItem
labels
Mar 19, 2020
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: list
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ListItemText with secondaryTypographyProps rendering on same line as primary.
Closes #19943