-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Display color preview in IntelliSense #20079
[docs] Display color preview in IntelliSense #20079
Conversation
eps1lon
commented
Mar 11, 2020
•
edited
Loading
edited
Details of bundle changes.Comparing: 7102777...75d4ea8 Details of page changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pretty cool DX improvement :D
const HOST = 'https://material-ui.com/'; | ||
|
||
function getColorHref(name, variant) { | ||
return `static/colors-preview/${name}-${variant}-24x24.svg`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use case for including the size of the svg?
return `static/colors-preview/${name}-${variant}-24x24.svg`; | |
return `static/colors-preview/${name}-${variant}.svg`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so that we know it. Adds an easy "button" if we want to change the size and invalidate downstream caches.