Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styles] Fix theme default props overriden by Component default props #20091

Merged
merged 1 commit into from
Mar 16, 2020
Merged

[styles] Fix theme default props overriden by Component default props #20091

merged 1 commit into from
Mar 16, 2020

Conversation

adridavid
Copy link
Contributor

Fixes #20090

@oliviertassinari
Copy link
Member

You can blame to gain more context on the current logic

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 7102777...5c5cf36

Details of page changes
bundle Size Change Size Gzip Change Gzip
docs:chunks/1c3857e55da0a4be64cf846284432a6c6fc97cc4.e4fec7.js ▼ -14.9 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/9e65bf52f0ea79f41c76acee2d07e158b0060746.e4fec7.js ▲ +14.9 kB (+Infinity% ) 14.9 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/6948ec1bf1737c34bba9effc3cacee63cdf372e6.4b865e.js ▼ -14.3 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/6ec81c588ee9a94a13e3f77e1cd11e61e8b44e87.23d094.js ▲ +14.3 kB (+Infinity% ) 14.3 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/08c44e393fe352fc42faf0e49311a3b795fd9ebe.25a992.js ▲ +13.9 kB (+Infinity% ) 13.9 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/afbf44159676cded1ca1350fd8cabc575cf3dfe3.25a992.js ▼ -13.9 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/dc9a35ada19f227e2357c79d689152aee717eaa5.c16f0a.js ▲ +8.22 kB (+Infinity% ) 8.22 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/f0c82a3b82b8ebc1ddafe3daadc51cb0220dc4ec.c16f0a.js ▼ -8.22 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/0297cd01ce69ca4a8d03c11bd8e43b163120f37b.f1aa72.js ▲ +7.32 kB (+Infinity% ) 7.32 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/50b78b9fe444201061489ce8a4c72fcb3422d343.f1aa72.js ▼ -7.32 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/bceaece18084dbb967905c1dd22b3a007dbe093b.832236.js ▼ -5.74 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:chunks/d52883f01334451d100fd49be13dfa5506c23edd.b06403.js ▲ +5.74 kB (+Infinity% ) 5.74 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/50ed0e8e84e5564c432aebc7f1991aa8f959937b.4b1ac1.js ▲ +2.81 kB (+Infinity% ) 2.81 kB ▼ -1 B (-Infinity% ) -1 B
docs:chunks/ae915515a223da411cd25b0c19d71029d73fac8d.d0a0b7.js ▼ -2.81 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:runtime/webpack.334596.js ▼ -1.24 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
docs:runtime/webpack.55aa11.js ▲ +1.24 kB (+Infinity% ) 1.24 kB ▼ -1 B (-Infinity% ) -1 B
/performance/table-emotion ▼ -10 B (-0.34% ) 2.96 kB -- -1 B
/_app -- 33.9 kB -- -1 B
/api-docs/alert-title -- 1.12 kB -- -1 B
/api-docs/alert -- 2.15 kB -- -1 B
/api-docs/app-bar -- 1.69 kB -- -1 B
/api-docs/autocomplete -- 3.86 kB -- -1 B
/api-docs/avatar-group -- 1.23 kB -- -1 B
/api-docs/avatar -- 1.61 kB -- -1 B
/api-docs/backdrop -- 1.38 kB -- -1 B
/api-docs/badge -- 1.88 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.55 kB -- -1 B
/api-docs/bottom-navigation -- 1.43 kB -- -1 B
/api-docs/breadcrumbs -- 1.59 kB -- -1 B
/api-docs/button-base -- 2.08 kB -- -1 B
/api-docs/button-group -- 1.95 kB -- -1 B
/api-docs/button -- 2.32 kB -- -1 B
/api-docs/card-action-area -- 1.32 kB -- -1 B
/api-docs/card-actions -- 1.22 kB -- -1 B
/api-docs/card-content -- 1.2 kB -- -1 B
/api-docs/card-header -- 1.53 kB -- -1 B
/api-docs/card-media -- 1.43 kB -- -1 B
/api-docs/card -- 1.25 kB -- -1 B
/api-docs/checkbox -- 2.05 kB -- -1 B
/api-docs/chip -- 2.19 kB -- -1 B
/api-docs/circular-progress -- 1.8 kB -- -1 B
/api-docs/click-away-listener -- 1.13 kB -- -1 B
/api-docs/collapse -- 1.76 kB -- -1 B
/api-docs/container -- 1.62 kB -- -1 B
/api-docs/css-baseline -- 1.14 kB -- -1 B
/api-docs/dialog-actions -- 1.22 kB -- -1 B
/api-docs/dialog-content-text -- 1.23 kB -- -1 B
/api-docs/dialog-content -- 1.2 kB -- -1 B
/api-docs/dialog-title -- 1.26 kB -- -1 B
/api-docs/dialog -- 2.48 kB -- -1 B
/api-docs/divider -- 1.55 kB -- -1 B
/api-docs/drawer -- 1.87 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.25 kB -- -1 B
/api-docs/expansion-panel-details -- 1.18 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.46 kB -- -1 B
/api-docs/expansion-panel -- 1.7 kB -- -1 B
/api-docs/fab -- 1.86 kB -- -1 B
/api-docs/fade -- 1.17 kB -- -1 B
/api-docs/filled-input -- 2.65 kB -- -1 B
/api-docs/form-control-label -- 1.73 kB -- -1 B
/api-docs/form-control -- 2.1 kB -- -1 B
/api-docs/form-group -- 1.3 kB -- -1 B
/api-docs/form-helper-text -- 1.66 kB -- -1 B
/api-docs/form-label -- 1.59 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.54 kB -- -1 B
/api-docs/grid-list-tile -- 1.46 kB -- -1 B
/api-docs/grid-list -- 1.37 kB -- -1 B
/api-docs/grid -- 2.29 kB -- -1 B
/api-docs/grow -- 1.23 kB -- -1 B
/api-docs/hidden -- 1.32 kB -- -1 B
/api-docs/icon-button -- 1.85 kB -- -1 B
/api-docs/icon -- 1.54 kB -- -1 B
/api-docs/input-adornment -- 1.68 kB -- -1 B
/api-docs/input-base -- 2.74 kB -- -1 B
/api-docs/input-label -- 1.82 kB -- -1 B
/api-docs/input -- 2.61 kB -- -1 B
/api-docs/linear-progress -- 1.78 kB -- -1 B
/api-docs/link -- 1.68 kB -- -1 B
/api-docs/list-item-avatar -- 1.25 kB -- -1 B
/api-docs/list-item-icon -- 1.27 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.22 kB -- -1 B
/api-docs/list-item-text -- 1.54 kB -- -1 B
/api-docs/list-item -- 2 kB -- -1 B
/api-docs/list-subheader -- 1.51 kB -- -1 B
/api-docs/list -- 1.44 kB -- -1 B
/api-docs/menu-item -- 1.46 kB -- -1 B
/api-docs/menu-list -- 1.33 kB -- -1 B
/api-docs/menu -- 2.12 kB -- -1 B
/api-docs/mobile-stepper -- 1.67 kB -- -1 B
/api-docs/modal -- 2.14 kB -- -1 B
/api-docs/native-select -- 1.83 kB -- -1 B
/api-docs/no-ssr -- 1.09 kB -- -1 B
/api-docs/outlined-input -- 2.76 kB -- -1 B
/api-docs/pagination-item -- 1.71 kB -- -1 B
/api-docs/pagination -- 1.98 kB -- -1 B
/api-docs/paper -- 1.61 kB -- -1 B
/api-docs/popover -- 2.5 kB -- -1 B
/api-docs/popper -- 1.76 kB -- -1 B
/api-docs/portal -- 1.12 kB -- -1 B
/api-docs/radio-group -- 1.2 kB -- -1 B
/api-docs/radio -- 1.89 kB -- -1 B
/api-docs/rating -- 2.25 kB -- -1 B
/api-docs/root-ref -- 1.2 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.15 kB -- -1 B
/api-docs/select -- 2.65 kB -- -1 B
/api-docs/skeleton -- 1.52 kB -- -1 B
/api-docs/slide -- 1.31 kB -- -1 B
/api-docs/slider -- 2.85 kB -- -1 B
/api-docs/snackbar-content -- 1.36 kB -- -1 B
/api-docs/snackbar -- 2.46 kB -- -1 B
/api-docs/speed-dial-action -- 1.67 kB -- -1 B
/api-docs/speed-dial-icon -- 1.29 kB -- -1 B
/api-docs/speed-dial -- 2.05 kB -- -1 B
/api-docs/step-button -- 1.38 kB -- -1 B
/api-docs/step-connector -- 1.29 kB -- -1 B
/api-docs/step-content -- 1.47 kB -- -1 B
/api-docs/step-icon -- 1.33 kB -- -1 B
/api-docs/step-label -- 1.64 kB -- -1 B
/api-docs/step -- 1.38 kB -- -1 B
/api-docs/stepper -- 1.6 kB -- -1 B
/api-docs/svg-icon -- 2.01 kB -- -1 B
/api-docs/swipeable-drawer -- 1.78 kB -- -1 B
/api-docs/switch -- 2.19 kB -- -1 B
/api-docs/tab -- 1.74 kB -- -1 B
/api-docs/table-body -- 1.21 kB -- -1 B
/api-docs/table-cell -- 1.87 kB -- -1 B
/api-docs/table-container -- 1.22 kB -- -1 B
/api-docs/table-footer -- 1.22 kB -- -1 B
/api-docs/table-head -- 1.21 kB -- -1 B
/api-docs/table-pagination -- 2.21 kB -- -1 B
/api-docs/table-row -- 1.43 kB -- -1 B
/api-docs/table-sort-label -- 1.57 kB -- -1 B
/api-docs/table -- 1.43 kB -- -1 B
/api-docs/tabs -- 2.28 kB -- -1 B
/api-docs/text-field -- 2.94 kB -- -1 B
/api-docs/textarea-autosize -- 908 B -- -1 B
/api-docs/toggle-button-group -- 1.56 kB -- -1 B
/api-docs/toggle-button -- 1.55 kB -- -1 B
/api-docs/toolbar -- 1.4 kB -- -1 B
/api-docs/tooltip -- 2.3 kB -- -1 B
/api-docs/tree-item -- 1.53 kB -- -1 B
/api-docs/tree-view -- 1.67 kB -- -1 B
/api-docs/typography -- 2.33 kB -- -1 B
/api-docs/zoom -- 1.19 kB -- -1 B
/blog/2019-developer-survey-results -- 5.94 kB -- -1 B
/blog/2019 -- 3.82 kB -- -1 B
/blog/april-2019-update -- 2.71 kB -- -1 B
/blog/august-2019-update -- 1.82 kB -- -1 B
/blog/december-2019-update -- 1.96 kB -- -1 B
/blog/july-2019-update -- 1.71 kB -- -1 B
/blog/june-2019-update -- 1.58 kB -- -1 B
/blog/march-2019-update -- 2.12 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.25 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.28 kB -- -1 B
/blog/may-2019-update -- 1.91 kB -- -1 B
/blog/november-2019-update -- 2.32 kB -- -1 B
/blog/october-2019-update -- 2.06 kB -- -1 B
/blog/september-2019-update -- 2.25 kB -- -1 B
/company/about -- 1.51 kB -- -1 B
/company/contact -- 1.1 kB -- -1 B
/company/jobs -- 1.11 kB -- -1 B
/company/software-engineer -- 5.03 kB -- -1 B
/components/about-the-lab -- 3.19 kB -- -1 B
/components/alert -- 11.1 kB -- -1 B
/components/app-bar -- 30.9 kB -- -1 B
/components/autocomplete -- 106 kB -- -1 B
/components/avatars -- 8.48 kB -- -1 B
/components/backdrop -- 3.51 kB -- -1 B
/components/badges -- 14.2 kB -- -1 B
/components/bottom-navigation -- 6.22 kB -- -1 B
/components/box -- 7.96 kB -- -1 B
/components/breadcrumbs -- 14.4 kB -- -1 B
/components/button-group -- 6.56 kB -- -1 B
/components/buttons -- 17.6 kB -- -1 B
/components/cards -- 16.8 kB -- -1 B
/components/checkboxes -- 16.9 kB -- -1 B
/components/chips -- 21.6 kB -- -1 B
/components/click-away-listener -- 3.39 kB -- -1 B
/components/container -- 3.6 kB -- -1 B
/components/css-baseline -- 5.86 kB -- -1 B
/components/dialogs -- 42.1 kB -- -1 B
/components/dividers -- 12.1 kB -- -1 B
/components/drawers -- 30.3 kB -- -1 B
/components/expansion-panels -- 20.1 kB -- -1 B
/components/floating-action-button -- 10.2 kB -- -1 B
/components/grid-list -- 11.9 kB -- -1 B
/components/grid -- 33.4 kB -- -1 B
/components/hidden -- 10.5 kB -- -1 B
/components/icons -- 22.3 kB -- -1 B
/components/links -- 6.83 kB -- -1 B
/components/lists -- 33 kB -- -1 B
/components/material-icons -- 708 kB -- -1 B
/components/menus -- 23.3 kB -- -1 B
/components/modal -- 11.5 kB -- -1 B
/components/no-ssr -- 5.02 kB -- -1 B
/components/pagination -- 6.75 kB -- -1 B
/components/paper -- 3.34 kB -- -1 B
/components/pickers -- 38.1 kB -- -1 B
/components/popover -- 14.7 kB -- -1 B
/components/popper -- 22.5 kB -- -1 B
/components/portal -- 3.29 kB -- -1 B
/components/progress -- 21.8 kB -- -1 B
/components/radio-buttons -- 15.5 kB -- -1 B
/components/rating -- 10.7 kB -- -1 B
/components/selects -- 25.5 kB -- -1 B
/components/skeleton -- 10.1 kB -- -1 B
/components/slider -- 14.5 kB -- -1 B
/components/snackbars -- 24.8 kB -- -1 B
/components/speed-dial -- 14.6 kB -- -1 B
/components/steppers -- 35.9 kB -- -1 B
/components/switches -- 16.5 kB -- -1 B
/components/tables -- 176 kB -- -1 B
/components/tabs -- 19.3 kB -- -1 B
/components/text-fields -- 53 kB -- -1 B
/components/textarea-autosize -- 2.81 kB -- -1 B
/components/toggle-button -- 10.5 kB -- -1 B
/components/tooltips -- 17.3 kB -- -1 B
/components/transfer-list -- 9.3 kB -- -1 B
/components/transitions -- 10.8 kB -- -1 B
/components/tree-view -- 11.1 kB -- -1 B
/components/typography -- 9.67 kB -- -1 B
/components/use-media-query -- 13.1 kB -- -1 B
/customization/breakpoints -- 15.2 kB -- -1 B
/customization/color -- 21.6 kB -- -1 B
/customization/components -- 37.9 kB -- -1 B
/customization/default-theme -- 7.99 kB -- -1 B
/customization/density -- 9.16 kB -- -1 B
/customization/globals -- 4.65 kB -- -1 B
/customization/palette -- 11.8 kB -- -1 B
/customization/spacing -- 2.51 kB -- -1 B
/customization/theming -- 17.4 kB -- -1 B
/customization/typography -- 10.9 kB -- -1 B
/customization/z-index -- 3.03 kB -- -1 B
/discover-more/backers -- 2.89 kB -- -1 B
/discover-more/changelog -- 1.37 kB -- -1 B
/discover-more/languages -- 3.32 kB -- -1 B
/discover-more/related-projects -- 6.02 kB -- -1 B
/discover-more/roadmap -- 3.67 kB -- -1 B
/discover-more/showcase -- 13.3 kB -- -1 B
/discover-more/team -- 6.5 kB -- -1 B
/discover-more/vision -- 7.03 kB -- -1 B
/getting-started/example-projects -- 6.17 kB -- -1 B
/getting-started/faq -- 31.8 kB -- -1 B
/getting-started/installation -- 7.05 kB -- -1 B
/getting-started/learn -- 7.88 kB -- -1 B
/getting-started/support -- 9.7 kB -- -1 B
/getting-started/supported-components -- 6.19 kB -- -1 B
/getting-started/supported-platforms -- 5.69 kB -- -1 B
/getting-started/templates -- 8.1 kB -- -1 B
/getting-started/templates/album -- 5.66 kB -- -1 B
/getting-started/templates/blog -- 7.42 kB -- -1 B
/getting-started/templates/checkout -- 11.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.56 kB -- -1 B
/getting-started/templates/pricing -- 7.86 kB -- -1 B
/getting-started/templates/sign-in-side -- 9.31 kB -- -1 B
/getting-started/templates/sign-in -- 9.54 kB -- -1 B
/getting-started/templates/sign-up -- 9.65 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.37 kB -- -1 B
/guides/api -- 17.4 kB -- -1 B
/guides/composition -- 14 kB -- -1 B
/guides/flow -- 2.21 kB -- -1 B
/guides/interoperability -- 10.8 kB -- -1 B
/guides/localization -- 19.7 kB -- -1 B
/guides/migration-v0x -- 7.23 kB -- -1 B
/guides/migration-v3 -- 20.8 kB -- -1 B
/guides/minimizing-bundle-size -- 8.86 kB -- -1 B
/guides/responsive-ui -- 4.16 kB -- -1 B
/guides/right-to-left -- 6.7 kB -- -1 B
/guides/server-rendering -- 8.38 kB -- -1 B
/guides/testing -- 8.33 kB -- -1 B
/guides/typescript -- 12.8 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-hook -- 2.22 kB -- -1 B
/performance/table-mui -- 4.34 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.61 kB -- -1 B
/premium-themes/onepirate -- 7.11 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 8.73 kB -- -1 B
/styles/advanced -- 30.2 kB -- -1 B
/styles/api -- 16 kB -- -1 B
/styles/basics -- 17.2 kB -- -1 B
/system/api -- 5.85 kB -- -1 B
/system/basics -- 25.2 kB -- -1 B
/system/borders -- 4.04 kB -- -1 B
/system/display -- 6.2 kB -- -1 B
/system/flexbox -- 5.71 kB -- -1 B
/system/palette -- 4.28 kB -- -1 B
/system/positions -- 2.46 kB -- -1 B
/system/shadows -- 3.44 kB -- -1 B
/system/sizing -- 3.34 kB -- -1 B
/system/spacing -- 6.05 kB -- -1 B
/system/typography -- 4.22 kB -- -1 B
/versions -- 22.7 kB -- -1 B
docs:chunks/commons.5243ee.js -- 5.99 kB -- -1 B
docs:chunks/framework.460644.js -- 42.3 kB -- -1 B
docs:runtime/main.1f9dd2.js -- 6.88 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
@material-ui/core[umd] ▼ -6 B (-0.00% ) 318 kB ▼ -1 B (-0.00% ) 92.2 kB
Drawer ▲ +4 B (0.00% ) 87.9 kB ▲ +4 B (+0.01% ) 26.8 kB
ExpansionPanel ▲ +4 B (+0.01% ) 74.9 kB ▲ +4 B (+0.02% ) 23.5 kB
MenuItem ▲ +4 B (0.00% ) 81.4 kB ▲ +4 B (+0.02% ) 25.4 kB
SwipeableDrawer ▲ +4 B (0.00% ) 95.3 kB ▲ +4 B (+0.01% ) 29.9 kB
BottomNavigationAction ▲ +4 B (+0.01% ) 78.8 kB ▲ +3 B (+0.01% ) 24.9 kB
ButtonBase ▲ +4 B (+0.01% ) 77.3 kB ▲ +3 B (+0.01% ) 24.2 kB
CardActionArea ▲ +4 B (+0.01% ) 78.4 kB ▲ +3 B (+0.01% ) 24.7 kB
Checkbox ▲ +4 B (0.00% ) 85.4 kB ▲ +3 B (+0.01% ) 27 kB
Dialog ▲ +4 B (0.00% ) 86.2 kB ▲ +3 B (+0.01% ) 26.9 kB
ExpansionPanelSummary ▲ +4 B (0.00% ) 81.4 kB ▲ +3 B (+0.01% ) 25.7 kB
Fab ▲ +4 B (0.00% ) 80.1 kB ▲ +3 B (+0.01% ) 24.9 kB
IconButton ▲ +4 B (+0.01% ) 79.4 kB ▲ +3 B (+0.01% ) 24.8 kB
ListItem ▲ +4 B (0.00% ) 80.3 kB ▲ +3 B (+0.01% ) 25.1 kB
Menu ▲ +4 B (0.00% ) 91.8 kB ▲ +3 B (+0.01% ) 28.3 kB
Pagination ▲ +4 B (0.00% ) 87.6 kB ▲ +3 B (+0.01% ) 27 kB
Popover ▲ +4 B (0.00% ) 86.3 kB ▲ +3 B (+0.01% ) 26.7 kB
Radio ▲ +4 B (0.00% ) 86.4 kB ▲ +3 B (+0.01% ) 27.3 kB
Select ▲ +4 B (0.00% ) 119 kB ▲ +3 B (+0.01% ) 35.3 kB
Slider ▲ +4 B (+0.01% ) 79.1 kB ▲ +3 B (+0.01% ) 25.2 kB
SpeedDial ▲ +4 B (0.00% ) 89.5 kB ▲ +3 B (+0.01% ) 28.3 kB
StepContent ▲ +4 B (+0.01% ) 72.5 kB ▲ +3 B (+0.01% ) 22.6 kB
TableSortLabel ▲ +4 B (0.00% ) 80.7 kB ▲ +3 B (+0.01% ) 25.5 kB
Tabs ▲ +4 B (0.00% ) 88.6 kB ▲ +3 B (+0.01% ) 28.3 kB
ToggleButton ▲ +4 B (+0.01% ) 79.4 kB ▲ +3 B (+0.01% ) 25.1 kB
TreeItem ▲ +4 B (+0.01% ) 78.5 kB ▲ +3 B (+0.01% ) 24.8 kB
AppBar ▲ +4 B (+0.01% ) 67.4 kB ▲ +2 B (+0.01% ) 21.1 kB
Autocomplete ▲ +4 B (0.00% ) 135 kB ▲ +2 B (0.00% ) 42.2 kB
Breadcrumbs ▲ +4 B (0.00% ) 83.7 kB ▲ +2 B (+0.01% ) 26.5 kB
ButtonGroup ▲ +4 B (0.00% ) 86.5 kB ▲ +2 B (+0.01% ) 26.6 kB
Chip ▲ +4 B (0.00% ) 85.9 kB ▲ +2 B (+0.01% ) 26.3 kB
Collapse ▲ +4 B (+0.01% ) 71.3 kB ▲ +2 B (+0.01% ) 22 kB
InputAdornment ▲ +4 B (+0.01% ) 68.4 kB ▲ +2 B (+0.01% ) 21.5 kB
MobileStepper ▲ +4 B (+0.01% ) 71.2 kB ▲ +2 B (+0.01% ) 22.3 kB
Rating ▲ +4 B (+0.01% ) 73.8 kB ▲ +2 B (+0.01% ) 23.7 kB
SpeedDialAction ▲ +4 B (0.00% ) 121 kB ▲ +2 B (+0.01% ) 38.4 kB
Switch ▲ +4 B (0.00% ) 84.6 kB ▲ +2 B (+0.01% ) 26.5 kB
Tab ▲ +4 B (+0.01% ) 79.6 kB ▲ +2 B (+0.01% ) 25.3 kB
TextField ▲ +4 B (0.00% ) 127 kB ▲ +2 B (+0.01% ) 37.3 kB
Typography ▲ +4 B (+0.01% ) 67 kB ▲ +2 B (+0.01% ) 20.9 kB
@material-ui/core ▲ +4 B (0.00% ) 360 kB ▲ +1 B (0.00% ) 98.8 kB
@material-ui/styles ▲ +4 B (+0.01% ) 51.4 kB ▲ +1 B (+0.01% ) 15.4 kB
Alert ▲ +4 B (0.00% ) 86.6 kB ▲ +1 B (0.00% ) 27.3 kB
Avatar ▲ +4 B (+0.01% ) 68.5 kB ▲ +1 B (0.00% ) 21.7 kB
Backdrop ▲ +4 B (+0.01% ) 71.2 kB ▲ +1 B (0.00% ) 21.9 kB
BottomNavigation ▲ +4 B (+0.01% ) 65.8 kB ▲ +1 B (0.00% ) 20.6 kB
Button ▲ +4 B (0.00% ) 83 kB ▲ +1 B (0.00% ) 25.4 kB
CardContent ▲ +4 B (+0.01% ) 65.3 kB ▲ +1 B (0.00% ) 20.4 kB
CardMedia ▲ +4 B (+0.01% ) 65.7 kB ▲ +1 B (0.00% ) 20.6 kB
Container ▲ +4 B (+0.01% ) 66.5 kB ▲ +1 B (0.00% ) 20.8 kB
DialogActions ▲ +4 B (+0.01% ) 65.4 kB ▲ +1 B (0.00% ) 20.5 kB
DialogContent ▲ +4 B (+0.01% ) 65.6 kB ▲ +1 B (0.00% ) 20.5 kB
Divider ▲ +4 B (+0.01% ) 66 kB ▲ +1 B (0.00% ) 20.7 kB
ExpansionPanelDetails ▲ +4 B (+0.01% ) 65.3 kB ▲ +1 B (0.00% ) 20.4 kB
FormControl ▲ +4 B (+0.01% ) 67.7 kB ▲ +1 B (0.00% ) 21.1 kB
FormHelperText ▲ +4 B (+0.01% ) 66.7 kB ▲ +1 B (0.00% ) 20.7 kB
Grid ▲ +4 B (+0.01% ) 68.5 kB ▲ +1 B (0.00% ) 21.4 kB
GridListTile ▲ +4 B (+0.01% ) 67.1 kB ▲ +1 B (0.00% ) 21 kB
GridListTileBar ▲ +4 B (+0.01% ) 66.6 kB ▲ +1 B (0.00% ) 20.8 kB
Hidden ▲ +4 B (+0.01% ) 69.3 kB ▲ +1 B (0.00% ) 21.7 kB
LinearProgress ▲ +4 B (+0.01% ) 68.7 kB ▲ +1 B (0.00% ) 21.2 kB
ListItemAvatar ▲ +4 B (+0.01% ) 65.5 kB ▲ +1 B (0.00% ) 20.5 kB
ListSubheader ▲ +4 B (+0.01% ) 66.1 kB ▲ +1 B (0.00% ) 20.8 kB
MenuList ▲ +4 B (+0.01% ) 69.3 kB ▲ +1 B (0.00% ) 21.7 kB
OutlinedInput ▲ +4 B (+0.01% ) 77.9 kB ▲ +1 B (0.00% ) 24.2 kB
PaginationItem ▲ +4 B (0.00% ) 84 kB ▲ +1 B (0.00% ) 25.9 kB
Paper ▲ +4 B (+0.01% ) 65.7 kB ▲ +1 B (0.00% ) 20.5 kB
RadioGroup ▲ +4 B (+0.01% ) 67.1 kB ▲ +1 B (0.00% ) 20.8 kB
ScopedCssBaseline ▲ +4 B (+0.01% ) 66.2 kB ▲ +1 B (0.00% ) 20.7 kB
SpeedDialIcon ▲ +4 B (+0.01% ) 67.9 kB ▲ +1 B (0.00% ) 21.3 kB
StepButton ▲ +4 B (0.00% ) 85.5 kB ▲ +1 B (0.00% ) 27 kB
StepConnector ▲ +4 B (+0.01% ) 66.1 kB ▲ +1 B (0.00% ) 20.8 kB
StepLabel ▲ +4 B (+0.01% ) 71.9 kB ▲ +1 B (0.00% ) 22.2 kB
Table ▲ +4 B (+0.01% ) 65.9 kB ▲ +1 B (0.00% ) 20.6 kB
TableBody ▲ +4 B (+0.01% ) 65.5 kB ▲ +1 B (0.00% ) 20.4 kB
TableCell ▲ +4 B (+0.01% ) 67.4 kB ▲ +1 B (0.00% ) 21.2 kB
TableContainer ▲ +4 B (+0.01% ) 65.3 kB ▲ +1 B (0.00% ) 20.4 kB
TableHead ▲ +4 B (+0.01% ) 65.5 kB ▲ +1 B (0.00% ) 20.5 kB
TablePagination ▲ +4 B (0.00% ) 145 kB ▲ +1 B (0.00% ) 42.6 kB
TableRow ▲ +4 B (+0.01% ) 65.8 kB ▲ +1 B (0.00% ) 20.6 kB
ToggleButtonGroup ▲ +4 B (+0.01% ) 66.6 kB ▲ +1 B (0.00% ) 20.9 kB
Toolbar ▲ +4 B (+0.01% ) 65.7 kB ▲ +1 B (0.00% ) 20.6 kB
Tooltip ▲ +4 B (0.00% ) 105 kB ▲ +1 B (0.00% ) 33.1 kB
TreeView ▲ +4 B (+0.01% ) 71.5 kB ▲ +1 B (0.00% ) 22.4 kB
@material-ui/lab ▲ +4 B (0.00% ) 199 kB -- 59 kB
AlertTitle ▲ +4 B (+0.01% ) 67.5 kB -- 21.2 kB
AvatarGroup ▲ +4 B (+0.01% ) 65.7 kB -- 20.6 kB
Badge ▲ +4 B (+0.01% ) 68.7 kB -- 21.3 kB
Card ▲ +4 B (+0.01% ) 66.2 kB -- 20.7 kB
CardActions ▲ +4 B (+0.01% ) 65.4 kB -- 20.5 kB
CardHeader ▲ +4 B (+0.01% ) 68.4 kB -- 21.5 kB
CircularProgress ▲ +4 B (+0.01% ) 67.5 kB -- 21.2 kB
CssBaseline ▲ +4 B (+0.01% ) 65.3 kB -- 20.5 kB
DialogContentText ▲ +4 B (+0.01% ) 67.4 kB -- 21.1 kB
DialogTitle ▲ +4 B (+0.01% ) 67.6 kB -- 21.2 kB
ExpansionPanelActions ▲ +4 B (+0.01% ) 65.4 kB -- 20.5 kB
FilledInput ▲ +4 B (+0.01% ) 76.9 kB -- 23.9 kB
FormControlLabel ▲ +4 B (+0.01% ) 68.8 kB -- 21.6 kB
FormGroup ▲ +4 B (+0.01% ) 65.4 kB -- 20.5 kB
FormLabel ▲ +4 B (+0.01% ) 66.8 kB -- 20.7 kB
GridList ▲ +4 B (+0.01% ) 65.8 kB -- 20.6 kB
Icon ▲ +4 B (+0.01% ) 66.1 kB -- 20.7 kB
Input ▲ +4 B (+0.01% ) 75.9 kB -- 23.7 kB
InputBase ▲ +4 B (+0.01% ) 74 kB -- 23.2 kB
InputLabel ▲ +4 B (+0.01% ) 68.6 kB -- 21.2 kB
Link ▲ +4 B (+0.01% ) 69.9 kB -- 22.1 kB
List ▲ +4 B (+0.01% ) 65.7 kB -- 20.4 kB
ListItemIcon ▲ +4 B (+0.01% ) 65.5 kB -- 20.5 kB
ListItemSecondaryAction ▲ +4 B (+0.01% ) 65.4 kB -- 20.4 kB
ListItemText ▲ +4 B (+0.01% ) 68.3 kB -- 21.5 kB
NativeSelect ▲ +4 B (0.00% ) 80.1 kB -- 25.3 kB
Skeleton ▲ +4 B (+0.01% ) 66.3 kB -- 20.9 kB
Snackbar ▲ +4 B (+0.01% ) 78.6 kB -- 24.5 kB
SnackbarContent ▲ +4 B (+0.01% ) 66.9 kB -- 21 kB
Step ▲ +4 B (+0.01% ) 66 kB -- 20.7 kB
StepIcon ▲ +4 B (+0.01% ) 67.9 kB -- 21.2 kB
Stepper ▲ +4 B (+0.01% ) 68.2 kB -- 21.5 kB
SvgIcon ▲ +4 B (+0.01% ) 66.4 kB -- 20.7 kB
TableFooter ▲ +4 B (+0.01% ) 65.5 kB -- 20.5 kB
@material-ui/system -- 16.6 kB -- 4.31 kB
Box -- 72.3 kB -- 21.8 kB
ClickAwayListener -- 3.84 kB -- 1.54 kB
colorManipulator -- 3.88 kB -- 1.52 kB
docs:/ -- 10.4 kB -- -1 B
docs:/_app -- 33.9 kB -- -1 B
Fade -- 27.1 kB -- 9.04 kB
Grow -- 27.7 kB -- 9.25 kB
Modal -- 14.3 kB -- 5.04 kB
NoSsr -- 2.17 kB -- 1.03 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.21 kB -- 1.64 kB
Slide -- 29.1 kB -- 9.78 kB
styles/createMuiTheme -- 20.9 kB -- 7.27 kB
TextareaAutosize -- 5.19 kB -- 2.17 kB
useAutocomplete -- 15 kB -- 5.38 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
Zoom -- 27.1 kB -- 9.17 kB

Generated by 🚫 dangerJS against 5c5cf36

@eps1lon
Copy link
Member

eps1lon commented Mar 13, 2020

You can blame to gain more context on the current logic

@oliviertassinari Which leads to a PR with test. That test still passes with the new implementation while also fixing what I consider a bug right now. When we say MyComponent should have variant="fancy" in MyTheme then this should override the default value of bland.

Either we're missing a test right now or we disagree on the behavior.

@oliviertassinari oliviertassinari added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. PR: ready to ship labels Mar 15, 2020
@eps1lon eps1lon merged commit 70c937d into mui:master Mar 16, 2020
@eps1lon
Copy link
Member

eps1lon commented Mar 16, 2020

@adridavid Thanks for the fix and test!

This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@adridavid @EsoterikStare
[styles] Fix theme default props overriden by Component defaul… (mui#…
641f63c 
…20091)
This was referenced Apr 10, 2020
Closed
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[styles] Theme default props are overriden by Component default props
4 participants
@adridavid @oliviertassinari @mui-pr-bot @eps1lon