-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ListItemText] Add JSDOC to typescript props #20171
Merged
eps1lon
merged 1 commit into
mui:master
from
eps1lon:docs/ListItemText/typescript-props
Mar 18, 2020
Merged
[ListItemText] Add JSDOC to typescript props #20171
eps1lon
merged 1 commit into
mui:master
from
eps1lon:docs/ListItemText/typescript-props
Mar 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 4fe9051...3ecd657 Details of page changes
|
@eps1lon Awesome! |
@@ -6,14 +6,42 @@ export interface ListItemTextProps< | |||
PrimaryTypographyComponent extends React.ElementType = 'span', | |||
SecondaryTypographyComponent extends React.ElementType = 'p' | |||
> extends StandardProps<React.HTMLAttributes<HTMLDivElement>, ListItemTextClassKey> { | |||
/** | |||
* Alias for the `primary` property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a new item in the next batch to rename property
-> prop
. This is part of https://trello.com/c/AxWGaWEw/1390-replace-property-prop-in-the-react-element-context.
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made possible with #19155.