-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix "fixed tags" demo #20687
Merged
oliviertassinari
merged 2 commits into
mui:master
from
kthyer:FixedTagsPreventRemoval-20532
Apr 22, 2020
Merged
[Autocomplete] Fix "fixed tags" demo #20687
oliviertassinari
merged 2 commits into
mui:master
from
kthyer:FixedTagsPreventRemoval-20532
Apr 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Autocomplete Fixed options demo Update FixedTags.tsx and FixedTags.js to prevent the removal of fixed tags in the Autocomplete demo by controlling the value state and ignoring all attempts to remove this tag.
kthyer
changed the title
Prevent removal of fixed tags from clear all button and backspace in …
[Autocomplete] Prevent removal of fixed tags from clear all button and backspace in demo
Apr 22, 2020
Details of bundle changes.Comparing: b9ddd6b...c14c491 Details of page changes
|
oliviertassinari
added
docs
Improvements or additions to the documentation
component: autocomplete
This is the name of the generic UI component, not the React module!
labels
Apr 22, 2020
oliviertassinari
changed the title
[Autocomplete] Prevent removal of fixed tags from clear all button and backspace in demo
[Autocomplete] Fix fixed tags demo
Apr 22, 2020
oliviertassinari
changed the title
[Autocomplete] Fix fixed tags demo
[Autocomplete] Fix "fixed tags" demo
Apr 22, 2020
@kthyer It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: autocomplete
This is the name of the generic UI component, not the React module!
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20532
Prevent removal of fixed tags from clear all button and backspace in Autocomplete Fixed options demo
Update FixedTags.tsx and FixedTags.js to prevent the removal of fixed tags in the Autocomplete demo by controlling the value state and ignoring all attempts to remove this tag.
Running
yarn lint
gives me'value' is already declared in the upper scope no-shadow
but I am unsure a better name for that variable for the PR.