[system] Improve breakpoints types #20753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakan85
changed the title
Details of bundle changes.Comparing: 3e5fd3c...360bfa9 Details of page changes
|
tarakan85
changed the title
eps1lon
previously requested changes
Apr 26, 2020
eps1lon
added
package: system
|
@nodeTempest I would be cautious with this approach, I'm not aware that we have test cases for it. |
|
Thank you for feedback. I added breakpointsTest and pointed expected result of my request. About css prop. Lets take a look look at one of tests: function cssTest() {
function styleFunction(props: { color?: string; spacing?: number; theme?: object }) {
return {};
}
const wideOrNarrowStyleFunction = css(styleFunction);
// narrow
wideOrNarrowStyleFunction({ theme: {}, css: { color: 'blue', spacing: 2 } });
// wide, undesire: `css` is required, marking it as optional breaks system/basics/#css-property
wideOrNarrowStyleFunction({ theme: {}, color: 'blue', spacing: 2, css: {} });
// wide and narrow
wideOrNarrowStyleFunction({ theme: {}, css: { color: 'blue', spacing: 2 }, color: 'red' });
}From second test I see that css prop is required and if you want to omit it you must specify it as css: {} |
| @@ -56,7 +56,7 @@ export function compose<T extends Array<StyleFunction<any>>>(...args: T): Compos | |||
| // css.js | |||
| export function css<Props>( | |||
| styleFunction: StyleFunction<Props> | |||
| ): StyleFunction<Props & { css: Omit<Props, 'theme'> }>; | |||
| ): StyleFunction<Props & { css?: Omit<Props, 'theme'> }>; | |||
There was a problem hiding this comment.
What about making a different pull request for the css concern? It would also be a good opportunity to add a JavaScript test case for it, I wasn't aware it was even working. Actually, I don't think that we should support it, rather encourage the other way around
oliviertassinari
changed the title
oliviertassinari
approved these changes
Apr 27, 2020
|
@nodeTempest Much appreciated, thanks! |
|
@oliviertassinari @eps1lon Thank you guys, I might create a new PR regarding css prop soon. |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys. Your awesome material-ui-system package allows doing this:
But current typescript implementation breaks everything.