-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix emojis/html being included in toc #20841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Something doesn't work
docs
Improvements or additions to the documentation
labels
Apr 29, 2020
eps1lon
commented
Apr 29, 2020
Details of bundle changes.Comparing: 5627473...6a0b345 Details of page changes
|
oliviertassinari
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :). Regarding the usage of them in the first place, the motivation was to have something a bit less boring to read, provide visual marks 😅.
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://twitter.com/zeroskillz/status/1255510295100952578, reported by @johnleider, as well as potential issues with emojis using the variation selector codepoint such as the warning emoji
Side note: Are these really necessary? I guess they're cute but is this appropriate in headings (especially in technical docs)?
Exampe: https://material-ui.netlify.app/getting-started/support/ vs http://deploy-preview-20841--material-ui.netlify.app/getting-started/support/