Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[numberfield] The largeStep prop should not round up/down #1010

Open
colmtuite opened this issue Dec 9, 2024 · 1 comment
Open

[numberfield] The largeStep prop should not round up/down #1010

colmtuite opened this issue Dec 9, 2024 · 1 comment
Labels
component: number field This is the name of the generic UI component, not the React module!

Comments

@colmtuite
Copy link
Contributor

colmtuite commented Dec 9, 2024

Instead, it should just add/subtract the largeStep value to/from the current value. We could have a prop perhaps, to change this behaviour to rounding.

Search keywords:

@colmtuite colmtuite added the component: number field This is the name of the generic UI component, not the React module! label Dec 9, 2024
@vladmoroz
Copy link
Contributor

We could have a prop perhaps, to change this behaviour to rounding.

If it's a prop, it should be more like a function for more fine-grained logic on increment/decrement, like onNudge = (currentValue) => newValue. Then you can implement any type of rounding or whatever custom logic that makes sense for your app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: number field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

2 participants