Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Promise based api in favor of loading prop #1454

Closed
dmtrKovalenko opened this issue Jan 16, 2020 · 1 comment · Fixed by #1829
Closed

Remove Promise based api in favor of loading prop #1454

dmtrKovalenko opened this issue Jan 16, 2020 · 1 comment · Fixed by #1829
Labels
breaking change enhancement New feature or request
Milestone

Comments

@dmtrKovalenko
Copy link
Member

dmtrKovalenko commented Jan 16, 2020

Also use Snackbar instead of spinner
cc @oliviertassinari

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 16, 2020

Thanks for opening this issue. We have talked about using the CircularProgress vs using the Skeleton and the bundle size impact it could have. I'm wondering about the frequency of these requirements. Also, I wonder what you have in mind with the Snackbar.

I think that there is an option we haven't explored yet.

What if we expose a customization API and leave the implementation of the loading behavior up to the users? (of course, we could need a demo, at least to make sure the DX is OK).

This would allow us to have a lighter component, and to constraint us to make sure the customization acceptable. Do you have usage stats on the current demo, relative to the others? It could help to know how frequent this need is. For instance, if it's less than 10%, not built-in support could make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants