Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement forwardRef #1604

Closed
oliviertassinari opened this issue Mar 26, 2020 · 2 comments
Closed

Implement forwardRef #1604

oliviertassinari opened this issue Mar 26, 2020 · 2 comments
Labels
bug 🐛 Something isn't working
Milestone
v5

Comments

@oliviertassinari
Copy link
Member

While #1593 is a great step forward, I believe there is still work needed to be done in order to match the expectations developers have built using the core components:

1. Public components missing forwardRef:

2. Ref not forwarded on the root element:

The ref is forwarded to the underlying <input> element, which is not the root element:

  • StaticTimePicker
  • MobileTimePicker
  • DesktopTimePicker
  • TimePicker
  • DatePicker
  • MobileDatePicker
  • StaticDatePicker
  • DekstopDatePicker
  • DateTimePicker
  • MobileDateTimePicker
  • StaticDateTimePicker
  • DekstopDateTimePicker

Environment

Tech Version
@material-ui/pickers v4.0.0-alpha.4

Steps to reproduce

https://codesandbox.io/s/gracious-haibt-0pnhc
@oliviertassinari oliviertassinari added the bug 🐛 Something isn't working label Mar 26, 2020
@oliviertassinari oliviertassinari added this to the v4 milestone Apr 6, 2020
@oliviertassinari oliviertassinari mentioned this issue Apr 9, 2020
Closed
19 tasks
@Philipp91 Philipp91 mentioned this issue Apr 24, 2020
Merged
@oliviertassinari oliviertassinari modified the milestones: v4, v5 Jul 13, 2020
@oliviertassinari oliviertassinari mentioned this issue Aug 2, 2020
Closed
2 tasks
@stunaz

This comment has been minimized.

Sign in to view
@oliviertassinari
Copy link
Member Author

@stunaz ?

@oliviertassinari oliviertassinari mentioned this issue May 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
v5
Development

No branches or pull requests
2 participants
@stunaz @oliviertassinari