Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export more types #1839

Closed
michael-land opened this issue May 31, 2020 · 10 comments · Fixed by #1846
Closed

Export more types #1839

michael-land opened this issue May 31, 2020 · 10 comments · Fixed by #1846

Comments

@michael-land
Copy link
Contributor

michael-land commented May 31, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

These types are very useful when integrated with other form libs or build on top of Date Input

// current
import { DateRange, RangeInput } from '@material-ui/pickers/src/DateRangePicker/RangeTypes';
import { BasePickerProps } from '@material-ui/pickers/src/typings/BasePicker';

// expect
import { DateRange, RangeInput, BasePickerProps } from '@material-ui/pickers';

Describe the solution you'd like
A clear and concise description of what you want to happen.

Export types such as BasePickerProps, DateRange, RangeInput

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@oliviertassinari
Copy link
Member

What's your use case?

@oliviertassinari oliviertassinari added the status: incomplete Need more information label May 31, 2020
@dmtrKovalenko
Copy link
Member

dmtrKovalenko commented May 31, 2020

It was done in the next branch. We reexported all the Props for all the components.

@oliviertassinari
Copy link
Member

@dmtrKovalenko should we export or not the types of the private components that we don't allow to override with theme.props? If we don't want to export them, do we?

@dmtrKovalenko
Copy link
Member

No, but BasePickerProps are actually shared props between all public root components, so we export them

@oliviertassinari
Copy link
Member

So we can close? :)

@dmtrKovalenko
Copy link
Member

I`d like to make sure everything is exported, and then close it

@oliviertassinari oliviertassinari added typescript and removed status: incomplete Need more information labels May 31, 2020
@oliviertassinari
Copy link
Member

@xiaoyu-tamu Could you try the next version out (v4.0.0-alpha.7)? :)

@michael-land
Copy link
Contributor Author

@xiaoyu-tamu Could you try the next version out (v4.0.0-alpha.7)? :)

Thanks. I will try the next version when it release.

v4.0.0-alpha.7 was released on May 6th.

@oliviertassinari
Copy link
Member

@xiaoyu-tamu Did you try v4.0.0-alpha.8?

@michael-land
Copy link
Contributor Author

Yes, it works👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants