[SelectInput] Fix event.target type in onChange callback

mui · Apr 11, 2019 · ffc6f5e · ffc6f5e
1 parent b4b4971
commit ffc6f5e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/docs/src/pages/demos/dialogs/MaxWidthDialog.js b/docs/src/pages/demos/dialogs/MaxWidthDialog.js
@@ -45,10 +45,8 @@ class MaxWidthDialog extends React.Component {
     this.setState({ open: false });
   };
 
-  handleMaxWidthChange = (event, value) => {
-    this.setState({
-      maxWidth: value,
-    });
+  handleMaxWidthChange = event => {
+    this.setState({ maxWidth: event.target.value });
   };
 
   handleFullWidthChange = event => {

diff --git a/docs/src/pages/demos/dialogs/MaxWidthDialog.tsx b/docs/src/pages/demos/dialogs/MaxWidthDialog.tsx
@@ -54,10 +54,8 @@ class MaxWidthDialog extends React.Component<MaxWidthDialogProps, MaxWidthDialog
     this.setState({ open: false });
   };
 
-  handleMaxWidthChange = (event: React.ChangeEvent<HTMLSelectElement>, value: any) => {
-    this.setState({
-      maxWidth: value as DialogProps['maxWidth'],
-    });
+  handleMaxWidthChange = (event: React.ChangeEvent<{ value: unknown }>) => {
+    this.setState({ maxWidth: event.target.value as MaxWidthDialogState['maxWidth'] });
   };
 
   handleFullWidthChange = (event: React.ChangeEvent<HTMLInputElement>) => {

diff --git a/packages/material-ui/src/Select/SelectInput.d.ts b/packages/material-ui/src/Select/SelectInput.d.ts
@@ -14,7 +14,10 @@ export interface SelectInputProps {
   name?: string;
   native: boolean;
   onBlur?: React.FocusEventHandler<any>;
-  onChange?: (event: React.ChangeEvent<HTMLSelectElement>, child: React.ReactNode) => void;
+  onChange?: (
+    event: React.ChangeEvent<{ name?: string; value: unknown }>,
+    child: React.ReactNode,
+  ) => void;
   onClose?: (event: React.ChangeEvent<{}>) => void;
   onFocus?: React.FocusEventHandler<any>;
   onOpen?: (event: React.ChangeEvent<{}>) => void;